201485 – [JSC] FunctionOverrides should have a lock to ensure concurrent access to hash table does not happen

Bug 201485 - [JSC] FunctionOverrides should have a lock to ensure concurrent access to hash table does not happen

Summary: [JSC] FunctionOverrides should have a lock to ensure concurrent access to has...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Yusuke Suzuki

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2019-09-04 19:11 PDT by Yusuke Suzuki
Modified:	2019-09-04 19:52 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (4.62 KB, patch) 2019-09-04 19:17 PDT, Yusuke Suzuki	tzagallo: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Yusuke Suzuki 2019-09-04 19:11:15 PDT

[JSC] FunctionOverrides should have a lock to ensure concurrent access to hash table does not happen

Comment 1 Yusuke Suzuki 2019-09-04 19:17:12 PDT

Created attachment 378036 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2019-09-04 19:17:43 PDT

<rdar://problem/55050943>

Comment 3 Yusuke Suzuki 2019-09-04 19:18:07 PDT

This is the cause of occasional crashes in testapi.
e.g. https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/16693/steps/webkit-jsc-cloop-test/logs/stdio

Comment 4 Tadeu Zagallo 2019-09-04 19:27:25 PDT

Comment on attachment 378036 [details]
Patch

r=me

Comment 5 Yusuke Suzuki 2019-09-04 19:52:54 PDT

Committed r249518: <https://trac.webkit.org/changeset/249518>