WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
201478
REGRESSION (
r249460
): LayoutTests/webgpu/viewport-scissor-rect-triangle-strip.html is Failing
https://bugs.webkit.org/show_bug.cgi?id=201478
Summary
REGRESSION (r249460): LayoutTests/webgpu/viewport-scissor-rect-triangle-strip...
Said Abou-Hallawa
Reported
2019-09-04 16:26:14 PDT
This layout test is failing consistently on macOS Catalina after <
https://trac.webkit.org/changeset/249460
>.
Attachments
Patch
(1.97 KB, patch)
2019-09-04 16:34 PDT
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Patch
(1.99 KB, patch)
2019-09-05 11:28 PDT
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Patch
(3.45 KB, patch)
2019-09-05 13:05 PDT
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Patch
(3.45 KB, patch)
2019-09-05 13:13 PDT
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Patch
(3.45 KB, patch)
2019-09-05 13:24 PDT
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1
2019-09-04 16:34:06 PDT
Created
attachment 378026
[details]
Patch
Said Abou-Hallawa
Comment 2
2019-09-04 16:41:39 PDT
I just learnt that webgpu layout tests are disabled on macOS High Sierra. And this is why I did not see this failure before landing
r249460
. This time I made sure all webgpu layout tests are passing with this change.
Russell Epstein
Comment 3
2019-09-05 11:02:15 PDT
Given Said's local testing, this patch looks ready for landing. Reviewers, can you confirm?
Simon Fraser (smfr)
Comment 4
2019-09-05 11:11:47 PDT
Comment on
attachment 378026
[details]
Patch Maybe the resource should just be re-encoded without the EXIF rotation.
Said Abou-Hallawa
Comment 5
2019-09-05 11:28:26 PDT
Created
attachment 378101
[details]
Patch
Said Abou-Hallawa
Comment 6
2019-09-05 11:33:16 PDT
(In reply to Simon Fraser (smfr) from
comment #4
)
> Comment on
attachment 378026
[details]
> Patch > > Maybe the resource should just be re-encoded without the EXIF rotation.
I changed the ChangeLog to have the correct description of the fix. Now we want to match the drawing of drawGreenAndBlueCheckerboardInSoftware() which was changed in
r249460
. I think also it is good that we have to deal with issues which the developers have to deal with after
r249364
and maybe they do not have the option to change the orientation of the images.
Said Abou-Hallawa
Comment 7
2019-09-05 13:05:03 PDT
Created
attachment 378107
[details]
Patch
Said Abou-Hallawa
Comment 8
2019-09-05 13:13:56 PDT
Created
attachment 378108
[details]
Patch
Said Abou-Hallawa
Comment 9
2019-09-05 13:24:41 PDT
Created
attachment 378110
[details]
Patch
WebKit Commit Bot
Comment 10
2019-09-10 13:37:08 PDT
Comment on
attachment 378110
[details]
Patch Clearing flags on attachment: 378110 Committed
r249732
: <
https://trac.webkit.org/changeset/249732
>
WebKit Commit Bot
Comment 11
2019-09-10 13:37:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12
2019-09-10 13:38:18 PDT
<
rdar://problem/55234788
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug