Bug 201477 - Replace defaultCustomPasteboardDataEnabled by an equivalent macro
Summary: Replace defaultCustomPasteboardDataEnabled by an equivalent macro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-04 16:07 PDT by Ryosuke Niwa
Modified: 2019-09-04 19:12 PDT (History)
2 users (show)

See Also:


Attachments
Cleanup (3.62 KB, patch)
2019-09-04 16:11 PDT, Ryosuke Niwa
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-09-04 16:07:04 PDT
https://trac.webkit.org/changeset/227282 introduced defaultCustomPasteboardDataEnabled() to disable the custom pasteboard data on iOS and macOS apps linked against old SDKs. However, this had a bug that the check inside WebContent would always return true. Because WebPreferences values aren't propagated from UI process to WebContent process unless there is a value change, it meant that custom pasteboard data is always enabled. Replace this function with a simple macro which always enables the custom pasteboard data on iOS and macOS.
Comment 1 Ryosuke Niwa 2019-09-04 16:11:11 PDT
Created attachment 378024 [details]
Cleanup
Comment 2 Ryosuke Niwa 2019-09-04 19:11:24 PDT
Committed r249512: <https://trac.webkit.org/changeset/249512>
Comment 3 Radar WebKit Bug Importer 2019-09-04 19:12:17 PDT
<rdar://problem/55050818>