Bug 201476 – Fix implicit conversion that loses precision

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Keith Rollin]

Building for watchOS results in the following error:

.../Source/WebCore/fileapi/NetworkSendQueue.cpp:66:42: error: implicit conversion loses 
integer precision: 'unsigned long long' to 'unsigned int' [-Werror,-Wshorten-64-to-32]
        enqueue(JSC::ArrayBuffer::create(byteLength, 1), 0, 0);

Fix this with an ASSERT(isInBounds()) and a static_cast.

[Radar WebKit Bug Importer]

<rdar://problem/55043129>

[Keith Rollin]

Created attachment 378023 [details]
Patch

[Alex Christensen]

Comment on attachment 378023 [details]
Patch

WebKit style prefers "unsigned" over "unsigned int"
I think it would look nicer if we instead changed the line before this:
unsigned byteLength = blob.size();

[youenn fablet]

Comment on attachment 378023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378023&action=review

> Source/WebCore/fileapi/NetworkSendQueue.cpp:68
> +        enqueue(JSC::ArrayBuffer::create(static_cast<unsigned int>(byteLength), 1), 0, 0);

The ASSERT is unneeded, since byteLength is equal to 0.
We could write it as: enqueue(JSC::ArrayBuffer::create(0, 1), 0, 0);
But then the compiler will not know which ArrayBuffer::create to use.
I guess typing 0 as unsigned will make things clearer.

[Keith Rollin]

Youenn, I think you're saying to use the following?

JSC::ArrayBuffer::create(0U, 1)

I'm taking this route rather than Alex's suggestion, since his will still require a static_cast<>() at the point where byteLength is assigned.

I also removed the ASSERT().

[Keith Rollin]

Created attachment 378070 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 378070 [details]
Patch

Clearing flags on attachment: 378070

Committed r249527: <https://trac.webkit.org/changeset/249527>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alex Christensen]

Comment on attachment 378070 [details]
Patch

Wow, this change is much better.