Bug 201473 - Deprecate all WKCookieManagerRef functions
Summary: Deprecate all WKCookieManagerRef functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-04 15:29 PDT by Alex Christensen
Modified: 2019-09-06 13:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.69 KB, patch)
2019-09-04 15:33 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (46.66 KB, patch)
2019-09-04 18:36 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (46.68 KB, patch)
2019-09-04 19:29 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (51.17 KB, patch)
2019-09-05 08:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (51.20 KB, patch)
2019-09-05 08:44 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (51.22 KB, patch)
2019-09-05 16:51 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (51.23 KB, patch)
2019-09-05 17:18 PDT, Alex Christensen 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-09-04 15:29:18 PDT 
Deprecate all WKCookieManagerRef functions
Comment 1 Alex Christensen 2019-09-04 15:33:16 PDT 
Created attachment 378018 [details]
Patch
Comment 2 Alex Christensen 2019-09-04 17:04:31 PDT 
Comment on attachment 378018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378018&action=review

> Source/WebKit/UIProcess/API/C/WKContext.h:146
> +WK_EXPORT WKCookieManagerRef WKContextGetCookieManager(WKContextRef context) WK_C_API_DEPRECATED;

This is still used in a few tests :(
I'll replace it.
Comment 3 Alex Christensen 2019-09-04 18:36:54 PDT 
Created attachment 378034 [details]
Patch
Comment 4 Alex Christensen 2019-09-04 19:29:38 PDT 
Created attachment 378037 [details]
Patch
Comment 5 Alex Christensen 2019-09-05 08:24:41 PDT 
Created attachment 378084 [details]
Patch
Comment 6 Alex Christensen 2019-09-05 08:44:36 PDT 
Created attachment 378086 [details]
Patch
Comment 7 Alex Christensen 2019-09-05 16:51:49 PDT 
Created attachment 378137 [details]
Patch
Comment 8 Alex Christensen 2019-09-05 17:18:50 PDT 
Created attachment 378140 [details]
Patch
Comment 9 Alex Christensen 2019-09-06 08:52:03 PDT 
I'll add my new header to WebKit_PUBLIC_FRAMEWORK_HEADERS in PlatformWin.cmake before landing to fix the WinCairo build.
Comment 10 Alex Christensen 2019-09-06 13:42:55 PDT 
http://trac.webkit.org/r249589
Comment 11 Radar WebKit Bug Importer 2019-09-06 13:43:29 PDT 
<rdar://problem/55125643>