Bug 201468 - Remove unused SPI that accesses MemoryCache directly
Summary: Remove unused SPI that accesses MemoryCache directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-04 12:58 PDT by Alex Christensen
Modified: 2019-09-06 10:15 PDT (History)
13 users (show)

See Also:

Attachments
Patch (7.05 KB, patch)
2019-09-04 13:04 PDT, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
Patch (7.25 KB, patch)
2019-09-04 22:26 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-09-04 12:58:34 PDT 
Remove unused SPI that accesses MemoryCache directly
Comment 1 Alex Christensen 2019-09-04 13:04:41 PDT 
Created attachment 378004 [details]
Patch
Comment 2 Alex Christensen 2019-09-04 14:11:20 PDT 
http://trac.webkit.org/r249498
Comment 3 Radar WebKit Bug Importer 2019-09-04 14:12:20 PDT 
<rdar://problem/55037063>
Comment 4 Wenson Hsieh 2019-09-04 20:59:07 PDT 
Should we delete the API test WebKitLegacy.MemoryCacheAddImageToCache as well?
Comment 5 Ryosuke Niwa 2019-09-04 22:22:04 PDT 
Yeah, this broke iOS build :(
Comment 6 Ryosuke Niwa 2019-09-04 22:26:21 PDT 
Reopening to attach new patch.
Comment 7 Ryosuke Niwa 2019-09-04 22:26:22 PDT 
Created attachment 378046 [details]
Patch
Comment 8 Ryosuke Niwa 2019-09-04 22:26:58 PDT 
Please whoever wake up first / stay up late view & land this patch to fix iOS builds.
Comment 9 WebKit Commit Bot 2019-09-05 00:47:28 PDT 
Comment on attachment 378046 [details]
Patch

Clearing flags on attachment: 378046

Committed r249525: <https://trac.webkit.org/changeset/249525>
Comment 10 Alex Christensen 2019-09-06 10:15:54 PDT 
Sorry about that.  Thanks for the fix.