WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
201467
Expose WebPageProxy identifier to the Network Process
https://bugs.webkit.org/show_bug.cgi?id=201467
Summary
Expose WebPageProxy identifier to the Network Process
Chris Dumez
Reported
2019-09-04 12:51:49 PDT
Expose WebPageProxy identifier to the Network Process (similarly to WebPage / WebFrame identifiers) to that it can use it whenever it IPCs the UIProcess. The IPCs from the network process were the last one requiring the UIProcess to lookup a WebPageProxy object from a WebPageIdentifier (rather than a WebPageProxyIdentifier).
Attachments
Patch
(104.35 KB, patch)
2019-09-04 12:59 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(107.71 KB, patch)
2019-09-04 13:24 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(108.61 KB, patch)
2019-09-04 13:35 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(109.09 KB, patch)
2019-09-04 13:48 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(109.09 KB, patch)
2019-09-04 14:09 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2019-09-04 12:59:30 PDT
Created
attachment 378003
[details]
Patch
Chris Dumez
Comment 2
2019-09-04 13:24:30 PDT
Created
attachment 378007
[details]
Patch
Chris Dumez
Comment 3
2019-09-04 13:35:09 PDT
Created
attachment 378010
[details]
Patch
Chris Dumez
Comment 4
2019-09-04 13:48:31 PDT
Created
attachment 378011
[details]
Patch
Chris Dumez
Comment 5
2019-09-04 14:09:49 PDT
Created
attachment 378014
[details]
Patch
Geoffrey Garen
Comment 6
2019-09-04 15:13:03 PDT
Comment on
attachment 378014
[details]
Patch r=me
WebKit Commit Bot
Comment 7
2019-09-04 15:57:56 PDT
Comment on
attachment 378014
[details]
Patch Clearing flags on attachment: 378014 Committed
r249501
: <
https://trac.webkit.org/changeset/249501
>
WebKit Commit Bot
Comment 8
2019-09-04 15:57:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9
2019-09-04 15:58:18 PDT
<
rdar://problem/55042893
>
Chris Dumez
Comment 10
2019-09-04 16:13:20 PDT
Follow-up fix in <
https://trac.webkit.org/changeset/249502
> for WK2 debug.
Ryan Haddad
Comment 11
2019-09-04 16:31:58 PDT
This broke the Windows build:
https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/6481/steps/compile-webkit/logs/stdio
Chris Dumez
Comment 12
2019-09-04 18:48:06 PDT
(In reply to Ryan Haddad from
comment #11
)
> This broke the Windows build: >
https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/
> builds/6481/steps/compile-webkit/logs/stdio
Ok, looking now.
Chris Dumez
Comment 13
2019-09-04 19:37:04 PDT
(In reply to Chris Dumez from
comment #12
)
> (In reply to Ryan Haddad from
comment #11
) > > This broke the Windows build: > >
https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/
> > builds/6481/steps/compile-webkit/logs/stdio > > Ok, looking now.
Landed a build fix in <
https://trac.webkit.org/changeset/249515
>.
Fujii Hironori
Comment 14
2019-09-04 19:46:06 PDT
Comment on
attachment 378014
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=378014&action=review
> Source/WebCore/loader/EmptyFrameLoaderClient.h:27 > +#include <WebCore/ResourceError.h>
WinCairo builds get broken. This should be: #include "ResourceError.h" WebCore\loader\EmptyFrameLoaderClient.h(27): fatal error C1083: Cannot open include file: 'WebCore/ResourceError.h': No such file or directory
Chris Dumez
Comment 15
2019-09-04 20:00:28 PDT
Comment on
attachment 378014
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=378014&action=review
>> Source/WebCore/loader/EmptyFrameLoaderClient.h:27 >> +#include <WebCore/ResourceError.h> > > WinCairo builds get broken. This should be: > #include "ResourceError.h" > WebCore\loader\EmptyFrameLoaderClient.h(27): fatal error C1083: Cannot open include file: 'WebCore/ResourceError.h': No such file or directory
Thanks I was struggling to figure out the issue, done in <
https://trac.webkit.org/changeset/249519
>.
Fujii Hironori
Comment 16
2019-09-04 20:28:04 PDT
Thanks. Buildbots get back to green now.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug