Bug 201467 - Expose WebPageProxy identifier to the Network Process
Summary: Expose WebPageProxy identifier to the Network Process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-04 12:51 PDT by Chris Dumez
Modified: 2019-09-04 20:28 PDT (History)
12 users (show)

See Also:

Attachments
Patch (104.35 KB, patch)
2019-09-04 12:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (107.71 KB, patch)
2019-09-04 13:24 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (108.61 KB, patch)
2019-09-04 13:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (109.09 KB, patch)
2019-09-04 13:48 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (109.09 KB, patch)
2019-09-04 14:09 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-04 12:51:49 PDT 
Expose WebPageProxy identifier to the Network Process (similarly to WebPage / WebFrame identifiers) to that it can use it whenever it IPCs the UIProcess. The IPCs from the network process were the last one requiring the UIProcess to lookup a WebPageProxy object from a WebPageIdentifier (rather than a WebPageProxyIdentifier).
Comment 1 Chris Dumez 2019-09-04 12:59:30 PDT 
Created attachment 378003 [details]
Patch
Comment 2 Chris Dumez 2019-09-04 13:24:30 PDT 
Created attachment 378007 [details]
Patch
Comment 3 Chris Dumez 2019-09-04 13:35:09 PDT 
Created attachment 378010 [details]
Patch
Comment 4 Chris Dumez 2019-09-04 13:48:31 PDT 
Created attachment 378011 [details]
Patch
Comment 5 Chris Dumez 2019-09-04 14:09:49 PDT 
Created attachment 378014 [details]
Patch
Comment 6 Geoffrey Garen 2019-09-04 15:13:03 PDT 
Comment on attachment 378014 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2019-09-04 15:57:56 PDT 
Comment on attachment 378014 [details]
Patch

Clearing flags on attachment: 378014

Committed r249501: <https://trac.webkit.org/changeset/249501>
Comment 8 WebKit Commit Bot 2019-09-04 15:57:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-09-04 15:58:18 PDT 
<rdar://problem/55042893>
Comment 10 Chris Dumez 2019-09-04 16:13:20 PDT 
Follow-up fix in <https://trac.webkit.org/changeset/249502> for WK2 debug.
Comment 12 Chris Dumez 2019-09-04 18:48:06 PDT 
(In reply to Ryan Haddad from comment #11)
> This broke the Windows build:
> https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/
> builds/6481/steps/compile-webkit/logs/stdio

Ok, looking now.
Comment 13 Chris Dumez 2019-09-04 19:37:04 PDT 
(In reply to Chris Dumez from comment #12)
> (In reply to Ryan Haddad from comment #11)
> > This broke the Windows build:
> > https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/
> > builds/6481/steps/compile-webkit/logs/stdio
> 
> Ok, looking now.

Landed a build fix in <https://trac.webkit.org/changeset/249515>.
Comment 14 Fujii Hironori 2019-09-04 19:46:06 PDT 
Comment on attachment 378014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378014&action=review

> Source/WebCore/loader/EmptyFrameLoaderClient.h:27
> +#include <WebCore/ResourceError.h>

WinCairo builds get broken. This should be:
#include "ResourceError.h"
WebCore\loader\EmptyFrameLoaderClient.h(27): fatal error C1083: Cannot open include file: 'WebCore/ResourceError.h': No such file or directory
Comment 15 Chris Dumez 2019-09-04 20:00:28 PDT 
Comment on attachment 378014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378014&action=review

>> Source/WebCore/loader/EmptyFrameLoaderClient.h:27
>> +#include <WebCore/ResourceError.h>
> 
> WinCairo builds get broken. This should be:
> #include "ResourceError.h"
> WebCore\loader\EmptyFrameLoaderClient.h(27): fatal error C1083: Cannot open include file: 'WebCore/ResourceError.h': No such file or directory

Thanks I was struggling to figure out the issue, done in <https://trac.webkit.org/changeset/249519>.
Comment 16 Fujii Hironori 2019-09-04 20:28:04 PDT 
Thanks. Buildbots get back to green now.