Expose WebPageProxy identifier to the Network Process (similarly to WebPage / WebFrame identifiers) to that it can use it whenever it IPCs the UIProcess. The IPCs from the network process were the last one requiring the UIProcess to lookup a WebPageProxy object from a WebPageIdentifier (rather than a WebPageProxyIdentifier).
Created attachment 378003 [details] Patch
Created attachment 378007 [details] Patch
Created attachment 378010 [details] Patch
Created attachment 378011 [details] Patch
Created attachment 378014 [details] Patch
Comment on attachment 378014 [details] Patch r=me
Comment on attachment 378014 [details] Patch Clearing flags on attachment: 378014 Committed r249501: <https://trac.webkit.org/changeset/249501>
All reviewed patches have been landed. Closing bug.
<rdar://problem/55042893>
Follow-up fix in <https://trac.webkit.org/changeset/249502> for WK2 debug.
This broke the Windows build: https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/6481/steps/compile-webkit/logs/stdio
(In reply to Ryan Haddad from comment #11) > This broke the Windows build: > https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/ > builds/6481/steps/compile-webkit/logs/stdio Ok, looking now.
(In reply to Chris Dumez from comment #12) > (In reply to Ryan Haddad from comment #11) > > This broke the Windows build: > > https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/ > > builds/6481/steps/compile-webkit/logs/stdio > > Ok, looking now. Landed a build fix in <https://trac.webkit.org/changeset/249515>.
Comment on attachment 378014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378014&action=review > Source/WebCore/loader/EmptyFrameLoaderClient.h:27 > +#include <WebCore/ResourceError.h> WinCairo builds get broken. This should be: #include "ResourceError.h" WebCore\loader\EmptyFrameLoaderClient.h(27): fatal error C1083: Cannot open include file: 'WebCore/ResourceError.h': No such file or directory
Comment on attachment 378014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378014&action=review >> Source/WebCore/loader/EmptyFrameLoaderClient.h:27 >> +#include <WebCore/ResourceError.h> > > WinCairo builds get broken. This should be: > #include "ResourceError.h" > WebCore\loader\EmptyFrameLoaderClient.h(27): fatal error C1083: Cannot open include file: 'WebCore/ResourceError.h': No such file or directory Thanks I was struggling to figure out the issue, done in <https://trac.webkit.org/changeset/249519>.
Thanks. Buildbots get back to green now.