Bug 201464 - [LFC] Assert on FormattingContext escaping
Summary: [LFC] Assert on FormattingContext escaping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-04 11:31 PDT by zalan
Modified: 2019-09-04 13:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (17.32 KB, patch)
2019-09-04 11:40 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (17.37 KB, patch)
2019-09-04 11:48 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (17.36 KB, patch)
2019-09-04 12:58 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-09-04 11:31:51 PDT
We should not need to read display boxes in different formatting contexts apart from a few (justified) cases.
Comment 1 Radar WebKit Bug Importer 2019-09-04 11:32:14 PDT
<rdar://problem/55029574>
Comment 2 zalan 2019-09-04 11:40:15 PDT
Created attachment 377992 [details]
Patch
Comment 3 Antti Koivisto 2019-09-04 11:44:19 PDT
Comment on attachment 377992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377992&action=review

> Source/WebCore/layout/FormattingContext.h:72
> +    enum class EscapeType { AccesChildFormattingContext, AccessParentFormattingContext, AccessAncestorFormattingContext };

Typo "Acces"

Maybe split this into lines?
Comment 4 zalan 2019-09-04 11:48:34 PDT
Created attachment 377994 [details]
Patch
Comment 5 zalan 2019-09-04 12:58:49 PDT
Created attachment 378002 [details]
Patch
Comment 6 WebKit Commit Bot 2019-09-04 13:42:15 PDT
Comment on attachment 378002 [details]
Patch

Clearing flags on attachment: 378002

Committed r249497: <https://trac.webkit.org/changeset/249497>
Comment 7 WebKit Commit Bot 2019-09-04 13:42:17 PDT
All reviewed patches have been landed.  Closing bug.