Bug 201444 - [macOS] Unable to open local file from favorites bar
Summary: [macOS] Unable to open local file from favorites bar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-03 20:22 PDT by Per Arne Vollan
Modified: 2019-09-03 21:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.69 KB, patch)
2019-09-03 20:24 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-09-03 20:22:13 PDT
The sandbox extension handle should be created providing the pid of the receiving process.
Comment 1 Per Arne Vollan 2019-09-03 20:24:48 PDT
Created attachment 377951 [details]
Patch
Comment 2 Brent Fulgham 2019-09-03 20:26:40 PDT
Comment on attachment 377951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377951&action=review

r=me

> Source/WebKit/UIProcess/WebPageProxy.cpp:1068
> +        if (SandboxExtension::createHandleForReadByPid(resourceDirectoryURL.fileSystemPath(), process.processIdentifier(), sandboxExtensionHandle)) {

Yikes! How did we miss this path?
Comment 3 Per Arne Vollan 2019-09-03 20:30:53 PDT
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 377951 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377951&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:1068
> > +        if (SandboxExtension::createHandleForReadByPid(resourceDirectoryURL.fileSystemPath(), process.processIdentifier(), sandboxExtensionHandle)) {
> 
> Yikes! How did we miss this path?

I originally thought only the explicit references to "/" needed replacement, but also this one needs replacement. It actually resolves to "/" as well.

Thanks for reviewing!
Comment 4 WebKit Commit Bot 2019-09-03 21:11:14 PDT
Comment on attachment 377951 [details]
Patch

Clearing flags on attachment: 377951

Committed r249454: <https://trac.webkit.org/changeset/249454>
Comment 5 WebKit Commit Bot 2019-09-03 21:11:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-03 21:12:17 PDT
<rdar://problem/55005268>