Bug 201444 – [macOS] Unable to open local file from favorites bar

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

The sandbox extension handle should be created providing the pid of the receiving process.

[Per Arne Vollan]

Created attachment 377951 [details]
Patch

[Brent Fulgham]

Comment on attachment 377951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377951&action=review

r=me

> Source/WebKit/UIProcess/WebPageProxy.cpp:1068
> +        if (SandboxExtension::createHandleForReadByPid(resourceDirectoryURL.fileSystemPath(), process.processIdentifier(), sandboxExtensionHandle)) {

Yikes! How did we miss this path?

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #2)
> Comment on attachment 377951 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377951&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:1068
> > +        if (SandboxExtension::createHandleForReadByPid(resourceDirectoryURL.fileSystemPath(), process.processIdentifier(), sandboxExtensionHandle)) {
> 
> Yikes! How did we miss this path?

I originally thought only the explicit references to "/" needed replacement, but also this one needs replacement. It actually resolves to "/" as well.

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 377951 [details]
Patch

Clearing flags on attachment: 377951

Committed r249454: <https://trac.webkit.org/changeset/249454>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55005268>