Bug 201435 - REGRESSION (r249132): [macOS WK2] Layout Test inspector/layers/layerTreeDidChange.html is a flaky failure
Summary: REGRESSION (r249132): [macOS WK2] Layout Test inspector/layers/layerTreeDidCh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 200959
Blocks:
  Show dependency treegraph
 
Reported: 2019-09-03 14:19 PDT by Ryan Haddad
Modified: 2019-09-03 17:36 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.73 KB, patch)
2019-09-03 16:26 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2019-09-03 14:19:46 PDT
The following layout test is flaky on macOS WK2 bots, most frequently failing in the debug configuration.

inspector/layers/layerTreeDidChange.html

Probable cause:

Unknown. The first failure on the dashboard blames https://trac.webkit.org/log/webkit/?verbose=on&rev=249133&stop_rev=249132

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Flayers%2FlayerTreeDidChange.html



--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/inspector/layers/layerTreeDidChange-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/inspector/layers/layerTreeDidChange-actual.txt
@@ -3,11 +3,14 @@
 
 == Running test suite: LayerTree.layerTreeDidChange
 -- Running test case: LayerTree.layerTreeDidChange.WithRequest
+Layer tree changed
 Creating layer...
 Layer tree changed
 Creating layer...
 Layer tree changed
-PASS: LayerTreeDidChange should fire after layersForNode is called
+FAIL: LayerTreeDidChange should fire after layersForNode is called
+    Expected: 2
+    Actual: 3
 
 -- Running test case: LayerTree.layerTreeDidChange.WithoutRequest
 Creating layer...
Comment 1 Devin Rousso 2019-09-03 16:26:14 PDT
Created attachment 377930 [details]
Patch
Comment 2 Joseph Pecoraro 2019-09-03 16:27:54 PDT
Comment on attachment 377930 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2019-09-03 17:35:18 PDT
Comment on attachment 377930 [details]
Patch

Clearing flags on attachment: 377930

Committed r249447: <https://trac.webkit.org/changeset/249447>
Comment 4 WebKit Commit Bot 2019-09-03 17:35:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-09-03 17:36:21 PDT
<rdar://problem/54999525>