WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
201434
[GTK] Build failure in Debian Stable and Ubuntu LTS bots after
r249427
https://bugs.webkit.org/show_bug.cgi?id=201434
Summary
[GTK] Build failure in Debian Stable and Ubuntu LTS bots after r249427
Pablo Saavedra
Reported
2019-09-03 13:49:49 PDT
``` ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:179:9: error: ‘GstGLSyncMeta’ was not declared in this scope GstGLSyncMeta* meta = gst_buffer_get_gl_sync_meta(m_buffer); ^~~~~~~~~~~~~ ..```
Attachments
patch
(1.63 KB, patch)
2019-09-03 13:51 PDT
,
Pablo Saavedra
no flags
Details
Formatted Diff
Diff
patch
(3.09 KB, patch)
2019-09-03 23:07 PDT
,
Pablo Saavedra
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pablo Saavedra
Comment 1
2019-09-03 13:51:56 PDT
Created
attachment 377918
[details]
patch
Pablo Saavedra
Comment 2
2019-09-03 13:57:36 PDT
The current patch fix the build but maybe the right patch for this case also it should restore the logic replaced by
r249427
in L719: ``` 719 GLuint textureID = frameHolder->textureID(); 720 std::unique_ptr<TextureMapperPlatformLayerBuffer> layerBuffer; 721 if (textureID) { 722 layerBuffer = makeUnique<TextureMapperPlatformLayerBuffer>(textureID, frameHolder->size(), frameHolder->flags(), GraphicsContext3D::RGBA); ```
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp?rev=249321#L719
Pablo Saavedra
Comment 3
2019-09-03 14:18:57 PDT
(In reply to Pablo Saavedra from
comment #2
)
> The current patch fix the build but maybe the right patch for this case also > it should restore the logic replaced by
r249427
in L719: > > ``` > 719 GLuint textureID = frameHolder->textureID(); > 720 std::unique_ptr<TextureMapperPlatformLayerBuffer> > layerBuffer; > 721 if (textureID) { > 722 layerBuffer = > makeUnique<TextureMapperPlatformLayerBuffer>(textureID, frameHolder->size(), > frameHolder->flags(), GraphicsContext3D::RGBA); > ``` > >
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/
> graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp?rev=249321#L719
Nah, only is invoked in sections of the code already safeguarded by `#if USE(GSTREAMER_GL)`
Pablo Saavedra
Comment 4
2019-09-03 23:07:57 PDT
Created
attachment 377957
[details]
patch
WebKit Commit Bot
Comment 5
2019-09-04 01:29:20 PDT
Comment on
attachment 377957
[details]
patch Clearing flags on attachment: 377957 Committed
r249474
: <
https://trac.webkit.org/changeset/249474
>
WebKit Commit Bot
Comment 6
2019-09-04 01:29:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2019-09-04 01:30:19 PDT
<
rdar://problem/55010966
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug