Bug 201434 - [GTK] Build failure in Debian Stable and Ubuntu LTS bots after r249427
Summary: [GTK] Build failure in Debian Stable and Ubuntu LTS bots after r249427
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-03 13:49 PDT by Pablo Saavedra
Modified: 2019-09-04 01:30 PDT (History)
8 users (show)

See Also:


Attachments
patch (1.63 KB, patch)
2019-09-03 13:51 PDT, Pablo Saavedra
no flags Details | Formatted Diff | Diff
patch (3.09 KB, patch)
2019-09-03 23:07 PDT, Pablo Saavedra
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2019-09-03 13:49:49 PDT
```
../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:179:9: error: ‘GstGLSyncMeta’ was not declared in this scope
         GstGLSyncMeta* meta = gst_buffer_get_gl_sync_meta(m_buffer);
         ^~~~~~~~~~~~~
..```
Comment 1 Pablo Saavedra 2019-09-03 13:51:56 PDT
Created attachment 377918 [details]
patch
Comment 2 Pablo Saavedra 2019-09-03 13:57:36 PDT
The current patch fix the build but maybe the right patch for this case also it should restore the logic replaced by r249427 in L719:

```
719            GLuint textureID = frameHolder->textureID();
720	 	            std::unique_ptr<TextureMapperPlatformLayerBuffer> layerBuffer;
721	 	            if (textureID) {
722	 	                layerBuffer = makeUnique<TextureMapperPlatformLayerBuffer>(textureID, frameHolder->size(), frameHolder->flags(), GraphicsContext3D::RGBA);
```

https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp?rev=249321#L719
Comment 3 Pablo Saavedra 2019-09-03 14:18:57 PDT
(In reply to Pablo Saavedra from comment #2)
> The current patch fix the build but maybe the right patch for this case also
> it should restore the logic replaced by r249427 in L719:
> 
> ```
> 719            GLuint textureID = frameHolder->textureID();
> 720	 	            std::unique_ptr<TextureMapperPlatformLayerBuffer>
> layerBuffer;
> 721	 	            if (textureID) {
> 722	 	                layerBuffer =
> makeUnique<TextureMapperPlatformLayerBuffer>(textureID, frameHolder->size(),
> frameHolder->flags(), GraphicsContext3D::RGBA);
> ```
> 
> https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/
> graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp?rev=249321#L719

Nah,  only is invoked in sections of the code already safeguarded by `#if USE(GSTREAMER_GL)`
Comment 4 Pablo Saavedra 2019-09-03 23:07:57 PDT
Created attachment 377957 [details]
patch
Comment 5 WebKit Commit Bot 2019-09-04 01:29:20 PDT
Comment on attachment 377957 [details]
patch

Clearing flags on attachment: 377957

Committed r249474: <https://trac.webkit.org/changeset/249474>
Comment 6 WebKit Commit Bot 2019-09-04 01:29:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-09-04 01:30:19 PDT
<rdar://problem/55010966>