Bug 201428 - Rename WebPage::pageID() to WebPage::identifier()
Summary: Rename WebPage::pageID() to WebPage::identifier()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-03 10:05 PDT by Chris Dumez
Modified: 2019-09-03 11:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (77.45 KB, patch)
2019-09-03 10:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (81.56 KB, patch)
2019-09-03 10:34 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (86.91 KB, patch)
2019-09-03 10:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-03 10:05:38 PDT 
Rename WebPage::pageID() to WebPage::identifier(). Using "page" is the name is redundant here, using identifier() is more consistent with WebPageProxy::identifier().
Comment 1 Chris Dumez 2019-09-03 10:06:20 PDT 
Created attachment 377903 [details]
Patch
Comment 2 Chris Dumez 2019-09-03 10:34:58 PDT 
Created attachment 377905 [details]
Patch
Comment 3 Chris Dumez 2019-09-03 10:41:05 PDT 
Created attachment 377906 [details]
Patch
Comment 4 WebKit Commit Bot 2019-09-03 11:37:43 PDT 
Comment on attachment 377906 [details]
Patch

Clearing flags on attachment: 377906

Committed r249435: <https://trac.webkit.org/changeset/249435>
Comment 5 WebKit Commit Bot 2019-09-03 11:37:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-03 11:38:18 PDT 
<rdar://problem/54983782>