Bug 201426 - Allow run-jsc-stress-tests still run if some of the remote hosts are not available
Summary: Allow run-jsc-stress-tests still run if some of the remote hosts are not avai...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
Depends on: 213097
Blocks:
  Show dependency tree / graph
 
Reported: 2019-09-03 09:48 PDT by Caio Lima
Modified: 2020-06-11 15:29 PDT (History)
9 users (show)

See Also:

Attachments
WIP - Test (3.24 KB, patch)
2019-09-03 09:49 PDT, Caio Lima 		no flags Details | Formatted Diff | Diff
Patch (4.57 KB, patch)
2019-09-03 12:42 PDT, Caio Lima 		no flags Details | Formatted Diff | Diff
Patch (4.62 KB, patch)
2020-06-02 05:50 PDT, Caio Lima 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2019-09-03 09:48:22 PDT 
Now, if one of the listed remote hosts is not available, we will abort the run of the script. This is a problem mainly to ARMv7 and MIPS EWS, because we run tests in multiple devices, and if any of the bots are unavailable, we don't process any patch in the queue. Keeping this script executing if we have at least 1 remote host available will increase the robustness of those EWS bots.
Comment 1 Caio Lima 2019-09-03 09:49:35 PDT 
Created attachment 377901 [details]
WIP - Test
Comment 2 Caio Lima 2019-09-03 12:42:41 PDT 
Created attachment 377914 [details]
Patch
Comment 3 Guillaume Emont 2019-09-24 10:45:09 PDT 
Comment on attachment 377914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377914&action=review

The change looks good to me. It gives me loads of ideas of things to clean up in that script (such as having a function with fewer parameters to replace all the mysys("ssh", ....) calls), but that's beside the point.

> Tools/ChangeLog:3
> +        Allow run-jsc-stress-tests still run if some of the remote hosts are not available

grammar/clarity nitpick: Allow run-jsc-stress-tests to keep on running if some of the remote hosts are not available
Comment 4 Paulo Matos 2019-09-25 02:06:52 PDT 
Took a look at it as well, and besides Guillaume's nit, I have nothing to add. This is a very useful patch.
Comment 5 Caio Lima 2020-06-02 05:50:37 PDT 
Created attachment 400808 [details]
Patch
Comment 6 Caio Lima 2020-06-05 05:25:23 PDT 
Ping Review.

We are particularly interested into this patch because of our constant issues into MIPS EWS queue. The current hardware we have there is very faulty and we are using a dozen of them to run tests faster. Being able to keep consuming queue items if 1 or 2 boards are temporarily unavailable would be great to avoid skipping a lot of important patches. We already started looking for alternative MIPS hardware, but in the meantime, this patch can benefit a lot MIPS EWS queue wait time.
Comment 7 Saam Barati 2020-06-05 11:26:09 PDT 
Comment on attachment 400808 [details]
Patch

r=me
Comment 8 Caio Lima 2020-06-07 07:11:10 PDT 
Comment on attachment 400808 [details]
Patch

Thank you very much for the review!
Comment 9 EWS 2020-06-07 07:35:56 PDT 
Committed r262696: <https://trac.webkit.org/changeset/262696>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400808 [details].
Comment 10 Radar WebKit Bug Importer 2020-06-07 07:36:19 PDT 
<rdar://problem/64089436>
Comment 11 Yusuke Suzuki 2020-06-11 15:29:37 PDT 
Re-opened since this is blocked by bug 213097