RESOLVED FIXED201424
results.webkit.org: Increase default limit for LimitSlider 
https://bugs.webkit.org/show_bug.cgi?id=201424
Summary results.webkit.org: Increase default limit for LimitSlider
Jonathan Bedard
Reported 2019-09-03 09:18:52 PDT
Display 1000 commits/results by default. Depending on the frequency of commits (and test runs), this is about 2 weeks worth of data.
Attachments
Patch (2.51 KB, patch)
2019-09-03 09:21 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.54 KB, patch)
2019-09-03 10:11 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-09-03 09:21:23 PDT
Created attachment 377899 [details] Patch
Aakash Jain
Comment 2 2019-09-03 09:44:02 PDT
Comment on attachment 377899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377899&action=review > Tools/ChangeLog:3 > + results.webkit.org: Increase default size Bug title should be more descriptive. > Tools/ChangeLog:9 > + (LimitSlider): Increase the default limit, make limit slider liner instead of logarithmic. why linear now? Typo: liner. > Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js:170 > const maxRange = 1000; this variable seems unused after this change.
Jonathan Bedard
Comment 3 2019-09-03 10:06:30 PDT
(In reply to Aakash Jain from comment #2) > Comment on attachment 377899 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377899&action=review > > > Tools/ChangeLog:3 > > + results.webkit.org: Increase default size > > Bug title should be more descriptive. > > > Tools/ChangeLog:9 > > + (LimitSlider): Increase the default limit, make limit slider liner instead of logarithmic. > > why linear now? The logarithmic slider was not popular with the bot watchers, they pretty universally said it was strange to use. > > Typo: liner. > > > Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js:170 > > const maxRange = 1000; > > this variable seems unused after this change.
Jonathan Bedard
Comment 4 2019-09-03 10:11:36 PDT
Created attachment 377904 [details] Patch
WebKit Commit Bot
Comment 5 2019-09-03 11:07:04 PDT
Comment on attachment 377904 [details] Patch Clearing flags on attachment: 377904 Committed r249432: <https://trac.webkit.org/changeset/249432>
WebKit Commit Bot
Comment 6 2019-09-03 11:07:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-09-03 11:08:16 PDT
<rdar://problem/54982366>
Radar WebKit Bug Importer
Comment 8 2019-09-03 11:08:19 PDT
<rdar://problem/54982368>
Note You need to log in before you can comment on or make changes to this bug.