Bug 201424 - results.webkit.org: Increase default limit for LimitSlider
Summary: results.webkit.org: Increase default limit for LimitSlider
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-03 09:18 PDT by Jonathan Bedard
Modified: 2019-09-03 11:08 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.51 KB, patch)
2019-09-03 09:21 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (2.54 KB, patch)
2019-09-03 10:11 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-09-03 09:18:52 PDT
Display 1000 commits/results by default. Depending on the frequency of commits (and test runs), this is about 2 weeks worth of data.
Comment 1 Jonathan Bedard 2019-09-03 09:21:23 PDT
Created attachment 377899 [details]
Patch
Comment 2 Aakash Jain 2019-09-03 09:44:02 PDT
Comment on attachment 377899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377899&action=review

> Tools/ChangeLog:3
> +        results.webkit.org: Increase default size

Bug title should be more descriptive.

> Tools/ChangeLog:9
> +        (LimitSlider): Increase the default limit, make limit slider liner instead of logarithmic.

why linear now?

Typo: liner.

> Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js:170
>      const maxRange = 1000;

this variable seems unused after this change.
Comment 3 Jonathan Bedard 2019-09-03 10:06:30 PDT
(In reply to Aakash Jain from comment #2)
> Comment on attachment 377899 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377899&action=review
> 
> > Tools/ChangeLog:3
> > +        results.webkit.org: Increase default size
> 
> Bug title should be more descriptive.
> 
> > Tools/ChangeLog:9
> > +        (LimitSlider): Increase the default limit, make limit slider liner instead of logarithmic.
> 
> why linear now?

The logarithmic slider was not popular with the bot watchers, they pretty universally said it was strange to use.

> 
> Typo: liner.
> 
> > Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js:170
> >      const maxRange = 1000;
> 
> this variable seems unused after this change.
Comment 4 Jonathan Bedard 2019-09-03 10:11:36 PDT
Created attachment 377904 [details]
Patch
Comment 5 WebKit Commit Bot 2019-09-03 11:07:04 PDT
Comment on attachment 377904 [details]
Patch

Clearing flags on attachment: 377904

Committed r249432: <https://trac.webkit.org/changeset/249432>
Comment 6 WebKit Commit Bot 2019-09-03 11:07:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-09-03 11:08:16 PDT
<rdar://problem/54982366>
Comment 8 Radar WebKit Bug Importer 2019-09-03 11:08:19 PDT
<rdar://problem/54982368>