RESOLVED FIXED 201415
[WPE] Make view backends multi-view-friendly 
https://bugs.webkit.org/show_bug.cgi?id=201415
Summary [WPE] Make view backends multi-view-friendly
Zan Dobersek
Reported 2019-09-02 23:20:35 PDT
[WPE] Make view backends multi-view-friendly
Attachments
Patch (13.89 KB, patch)
2019-09-02 23:27 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.41 KB, patch)
2019-09-03 03:43 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2019-09-02 23:27:20 PDT
Created attachment 377871 [details] Patch
Carlos Garcia Campos
Comment 2 2019-09-03 01:15:05 PDT
Comment on attachment 377871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377871&action=review > Tools/ChangeLog:7 > + Could you explain here why the changes make view backends multi-view-friendly? Looking at the patch it seems just a refactoring to move the code to initialize EGL. > Tools/wpe/backends/HeadlessViewBackend.cpp:61 > + if (!eglInitialize(eglDisplay, nullptr, nullptr)) Don't we need to do the eglBindAPI here too?
Zan Dobersek
Comment 3 2019-09-03 03:43:40 PDT
Created attachment 377885 [details] Patch for landing
Zan Dobersek
Comment 4 2019-09-03 03:45:48 PDT
Comment on attachment 377885 [details] Patch for landing Clearing flags on attachment: 377885 Committed r249424: <https://trac.webkit.org/changeset/249424>
Zan Dobersek
Comment 5 2019-09-03 03:45:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-03 03:46:18 PDT
<rdar://problem/54970698>
Note You need to log in before you can comment on or make changes to this bug.