Bug 201415 - [WPE] Make view backends multi-view-friendly
Summary: [WPE] Make view backends multi-view-friendly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-02 23:20 PDT by Zan Dobersek
Modified: 2019-09-03 03:46 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.89 KB, patch)
2019-09-02 23:27 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (14.41 KB, patch)
2019-09-03 03:43 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2019-09-02 23:20:35 PDT 
[WPE] Make view backends multi-view-friendly
Comment 1 Zan Dobersek 2019-09-02 23:27:20 PDT 
Created attachment 377871 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-09-03 01:15:05 PDT 
Comment on attachment 377871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377871&action=review

> Tools/ChangeLog:7
> +

Could you explain here why the changes make view backends multi-view-friendly? Looking at the patch it seems just a refactoring to move the code to initialize EGL.

> Tools/wpe/backends/HeadlessViewBackend.cpp:61
> +                if (!eglInitialize(eglDisplay, nullptr, nullptr))

Don't we need to do the eglBindAPI here too?
Comment 3 Zan Dobersek 2019-09-03 03:43:40 PDT 
Created attachment 377885 [details]
Patch for landing
Comment 4 Zan Dobersek 2019-09-03 03:45:48 PDT 
Comment on attachment 377885 [details]
Patch for landing

Clearing flags on attachment: 377885

Committed r249424: <https://trac.webkit.org/changeset/249424>
Comment 5 Zan Dobersek 2019-09-03 03:45:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-03 03:46:18 PDT 
<rdar://problem/54970698>