Bug 201413 - Remove the need to pass performJITMemcpy as a pointer.
Summary: Remove the need to pass performJITMemcpy as a pointer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-02 19:15 PDT by Mark Lam
Modified: 2019-09-03 18:47 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (28.45 KB, patch)
2019-09-02 19:18 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (29.15 KB, patch)
2019-09-03 08:14 PDT, Mark Lam 		msaboff: review+
Details | Formatted Diff | Diff
patch for landing. (29.25 KB, patch)
2019-09-03 10:03 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
patch for landing. (31.57 KB, patch)
2019-09-03 12:20 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
patch for landing. (31.58 KB, patch)
2019-09-03 13:08 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
patch for landing. (31.59 KB, patch)
2019-09-03 13:40 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
patch for landing w/ more speculative non-darwin build fixes. (32.03 KB, patch)
2019-09-03 15:03 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-09-02 19:15:23 PDT 
We can always use a direct branch.
Comment 1 Mark Lam 2019-09-02 19:15:44 PDT 
I meant, we can always use a direct call.
Comment 2 Mark Lam 2019-09-02 19:18:29 PDT 
Created attachment 377868 [details]
proposed patch.
Comment 3 Radar WebKit Bug Importer 2019-09-02 19:18:53 PDT 
<rdar://problem/54961451>
Comment 4 Mark Lam 2019-09-03 08:10:01 PDT 
(In reply to Mark Lam from comment #1)
> I meant, we can always use a direct call.

Actually, we want performJITMemcpy to always be inlined.
Comment 5 Mark Lam 2019-09-03 08:14:10 PDT 
Created attachment 377896 [details]
proposed patch.
Comment 6 Michael Saboff 2019-09-03 08:32:21 PDT 
Comment on attachment 377896 [details]
proposed patch.

r=me
Comment 7 Mark Lam 2019-09-03 10:03:17 PDT 
Created attachment 377902 [details]
patch for landing.

Thanks for the review.
Comment 8 Mark Lam 2019-09-03 12:20:32 PDT 
Created attachment 377912 [details]
patch for landing.
Comment 9 Mark Lam 2019-09-03 13:08:03 PDT 
Created attachment 377915 [details]
patch for landing.
Comment 10 Mark Lam 2019-09-03 13:40:20 PDT 
Created attachment 377917 [details]
patch for landing.
Comment 11 Mark Lam 2019-09-03 15:03:20 PDT 
Created attachment 377925 [details]
patch for landing w/ more speculative non-darwin build fixes.
Comment 12 Mark Lam 2019-09-03 18:47:40 PDT 
EWS bots are happy.

Landed in r249449: <http://trac.webkit.org/r249449>.