Make "clips compositing descendants" an indirect compositing reason
Created attachment 377805 [details] Patch
Comment on attachment 377805 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377805&action=review > Source/WebCore/ChangeLog:10 > + > + Whether a layer has to composite to clip composited descendants is an "indirect" reason, > + just like having to composite for filters if there's a composited descendant. So add > + IndirectCompositingReason::Clipping, and have computeIndirectCompositingReason() compute this. What is the goal/benefit of computing this?
(In reply to Sam Weinig from comment #2) > Comment on attachment 377805 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377805&action=review > > > Source/WebCore/ChangeLog:10 > > + > > + Whether a layer has to composite to clip composited descendants is an "indirect" reason, > > + just like having to composite for filters if there's a composited descendant. So add > > + IndirectCompositingReason::Clipping, and have computeIndirectCompositingReason() compute this. > > What is the goal/benefit of computing this? We already compute this. This patch is some cleanup prior to fixing bug 201330.
(In reply to Simon Fraser (smfr) from comment #3) > (In reply to Sam Weinig from comment #2) > > Comment on attachment 377805 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=377805&action=review > > > > > Source/WebCore/ChangeLog:10 > > > + > > > + Whether a layer has to composite to clip composited descendants is an "indirect" reason, > > > + just like having to composite for filters if there's a composited descendant. So add > > > + IndirectCompositingReason::Clipping, and have computeIndirectCompositingReason() compute this. > > > > What is the goal/benefit of computing this? > > We already compute this. This patch is some cleanup prior to fixing bug > 201330. Ok. Can you add that to the ChangeLog?
Created attachment 377854 [details] Patch
Comment on attachment 377854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377854&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:3069 > + return IndirectCompositingReason::None; Would be nice to modernise this to use Optional/OptionSet at some point.
https://trac.webkit.org/changeset/249434/webkit
<rdar://problem/54986805>