Bug 201378 - [LFC] Make FormattingContext::Geometry/Quirk/MarginCollapse c'tors private.
Summary: [LFC] Make FormattingContext::Geometry/Quirk/MarginCollapse c'tors private.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: LFC
  Show dependency tree / graph
 
Reported: 2019-08-31 05:51 PDT by zalan
Modified: 2022-10-10 10:00 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.02 KB, patch)
2019-08-31 05:52 PDT, zalan 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-08-31 05:51:24 PDT 
ssia
Comment 1 Radar WebKit Bug Importer 2019-08-31 05:52:03 PDT 
<rdar://problem/54914160>
Comment 2 zalan 2019-08-31 05:52:49 PDT 
Created attachment 377800 [details]
Patch
Comment 3 Sam Weinig 2019-08-31 15:51:26 PDT 
Comment on attachment 377800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377800&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +

Please explain why.
Comment 4 Ahmad Saleem 2022-10-10 10:00:01 PDT 
I checked with BugID on Webkit GitHub and it seems this r+ patch didn't landed. Thanks!