Bug 201377 - Add support to RTCDataChannel.send(Blob)
Summary: Add support to RTCDataChannel.send(Blob)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 201359
Blocks:
  Show dependency tree / graph
 
Reported: 2019-08-31 04:06 PDT by youenn fablet
Modified: 2019-09-10 05:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (11.37 KB, patch)
2019-08-31 04:14 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (11.10 KB, patch)
2019-09-05 00:03 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-08-31 04:06:27 PDT 
Add support to RTCDataChannel.send(Blob)
Comment 1 youenn fablet 2019-08-31 04:14:17 PDT 
Created attachment 377797 [details]
Patch
Comment 2 youenn fablet 2019-09-05 00:03:38 PDT 
Created attachment 378052 [details]
Patch
Comment 3 youenn fablet 2019-09-09 02:26:57 PDT 
ping review
Comment 4 Chris Dumez 2019-09-09 08:49:28 PDT 
Comment on attachment 378052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378052&action=review

> Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:87
> +    , m_messageQueue(createMessageQueue(downcast<Document>(context), *this))

Can the constructor be updated to take a Document& instead of having an unsafe-looking downcast here?
Comment 5 youenn fablet 2019-09-10 04:20:15 PDT 
(In reply to Chris Dumez from comment #4)
> Comment on attachment 378052 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378052&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:87
> > +    , m_messageQueue(createMessageQueue(downcast<Document>(context), *this))
> 
> Can the constructor be updated to take a Document& instead of having an
> unsafe-looking downcast here?

Right, let's do that as another patch since we should change RTCPeerConnection at the same time.
Comment 6 youenn fablet 2019-09-10 04:21:59 PDT 
> > Can the constructor be updated to take a Document& instead of having an
> > unsafe-looking downcast here?
> 
> Right, let's do that as another patch since we should change
> RTCPeerConnection at the same time.

Filed bug 201639.
Comment 7 WebKit Commit Bot 2019-09-10 05:04:51 PDT 
Comment on attachment 378052 [details]
Patch

Clearing flags on attachment: 378052

Committed r249710: <https://trac.webkit.org/changeset/249710>
Comment 8 WebKit Commit Bot 2019-09-10 05:04:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-09-10 05:05:19 PDT 
<rdar://problem/55219034>