Bug 201369 – [WebAuthn] Enable WebAuthn by default for MobileSafari and SafariViewService

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jiewen Tan]

Enable WebAuthn by default for MobileSafari and SafariViewService.

[Radar WebKit Bug Importer]

<rdar://problem/54903724>

[Jiewen Tan]

Created attachment 377775 [details]
Patch

[Brent Fulgham]

Comment on attachment 377775 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 377775 [details]
Patch

Clearing flags on attachment: 377775

Committed r249436: <https://trac.webkit.org/changeset/249436>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

Why don’t those clients just call in to WebKit and enable WebAuthn?

[Sam Weinig]

(In reply to mitz from comment #6)
> Why don’t those clients just call in to WebKit and enable WebAuthn?

I agree, this is a very unorthodox way of enabling a feature. We tend to keep bundle checks to the absolute minimum. What is preventing MobileSafari and SafariViewServices from enabling this themselves? Why is this only an issue on iOS?

[Jiewen Tan]

(In reply to Sam Weinig from comment #7)
> (In reply to mitz from comment #6)
> > Why don’t those clients just call in to WebKit and enable WebAuthn?
> 
> I agree, this is a very unorthodox way of enabling a feature. We tend to
> keep bundle checks to the absolute minimum. What is preventing MobileSafari
> and SafariViewServices from enabling this themselves? Why is this only an
> issue on iOS?

Right, that's a good idea. I should do that instead. Will follow up with patches on Internal.

In macOS, applications are not required to be sandboxed. If they are not, they don't need any entitlements to enable the feature. Also, we don't have that many browser like clients in macOS. They probably never hit this path. In iOS, however, the story is the opposite way.

I was not quite sure if I should do it for macOS as well. Now, I think I should.

[Sam Weinig]

(In reply to Jiewen Tan from comment #8)
> (In reply to Sam Weinig from comment #7)
> > (In reply to mitz from comment #6)
> > > Why don’t those clients just call in to WebKit and enable WebAuthn?
> > 
> > I agree, this is a very unorthodox way of enabling a feature. We tend to
> > keep bundle checks to the absolute minimum. What is preventing MobileSafari
> > and SafariViewServices from enabling this themselves? Why is this only an
> > issue on iOS?
> 
> Right, that's a good idea. I should do that instead. Will follow up with
> patches on Internal.
> 
> In macOS, applications are not required to be sandboxed. If they are not,
> they don't need any entitlements to enable the feature. Also, we don't have
> that many browser like clients in macOS. They probably never hit this path.
> In iOS, however, the story is the opposite way.
> 
> I was not quite sure if I should do it for macOS as well. Now, I think I
> should.

Matching iOS and macOS should generally be preferred, unless there is a really compelling reason not to.