Bug 201364 – DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID. pageID is redundant since it is being ignored by the callee. For the frame, simply pass the frame object in.

[Chris Dumez]

Created attachment 377764 [details]
Patch

[John Wilander]

Comment on attachment 377764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377764&action=review

LGTM. See nit.

> Source/WebCore/page/ChromeClient.h:-491
> -    virtual void requestStorageAccess(RegistrableDomain&& /*subFrameDomain*/, RegistrableDomain&& /*topFrameDomain*/, FrameIdentifier, PageIdentifier, WTF::CompletionHandler<void(StorageAccessWasGranted, StorageAccessPromptWasShown)>&& completionHandler) { completionHandler(StorageAccessWasGranted::No, StorageAccessPromptWasShown::No); }

Now you can remove #include "FrameIdentifier.h"

[Chris Dumez]

Created attachment 377771 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 377771 [details]
Patch

Clearing flags on attachment: 377771

Committed r249359: <https://trac.webkit.org/changeset/249359>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54911112>