Bug 201364 - DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID
Summary: DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-30 16:12 PDT by Chris Dumez
Modified: 2019-08-31 00:53 PDT (History)
9 users (show)

See Also:

Attachments
Patch (17.26 KB, patch)
2019-08-30 16:21 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (17.52 KB, patch)
2019-08-30 16:48 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-08-30 16:12:30 PDT 
DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID. pageID is redundant since it is being ignored by the callee. For the frame, simply pass the frame object in.
Comment 1 Chris Dumez 2019-08-30 16:21:52 PDT 
Created attachment 377764 [details]
Patch
Comment 2 John Wilander 2019-08-30 16:47:02 PDT 
Comment on attachment 377764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377764&action=review

LGTM. See nit.

> Source/WebCore/page/ChromeClient.h:-491
> -    virtual void requestStorageAccess(RegistrableDomain&& /*subFrameDomain*/, RegistrableDomain&& /*topFrameDomain*/, FrameIdentifier, PageIdentifier, WTF::CompletionHandler<void(StorageAccessWasGranted, StorageAccessPromptWasShown)>&& completionHandler) { completionHandler(StorageAccessWasGranted::No, StorageAccessPromptWasShown::No); }

Now you can remove #include "FrameIdentifier.h"
Comment 3 Chris Dumez 2019-08-30 16:48:45 PDT 
Created attachment 377771 [details]
Patch
Comment 4 WebKit Commit Bot 2019-08-31 00:52:26 PDT 
Comment on attachment 377771 [details]
Patch

Clearing flags on attachment: 377771

Committed r249359: <https://trac.webkit.org/changeset/249359>
Comment 5 WebKit Commit Bot 2019-08-31 00:52:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-31 00:53:17 PDT 
<rdar://problem/54911112>