Bug 201363 – [results.webkit.org Timeline] Add notify rerender API for timeline

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Zhifei Fang]

Because currently we don't have the resize observer implemented, I provide this API for user to call when his code change the layout and may affect the timeline width.

This API will let the timeline self adapt to it's parent flex box width, or user can give a fixed width, then the timeline will re-render to that specify width.

[Zhifei Fang]

Created attachment 377761 [details]
Patch

[Zhifei Fang]

Created attachment 377766 [details]
Patch

[Jonathan Bedard]

Comment on attachment 377766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377766&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:137
> +    const layoutSizeMayChange = new EventStream();

Feel like this should be something like 'onResizeActions' or 'onLayoutChangeActions'

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:149
> +                            /**

What prompted this new comment format? I know it's pretty common in projects which have some sort of auto-documenter, but we don't have that in WebKit.

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:155
> +                                // this make sure the newly added children receive current state

I would say:
'Propigate the current state to new children'

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:820
> +            

Nit: Extra newline?

> Tools/resultsdbpy/resultsdbpy/view/templates/search.html:45
> +

Nit: Extra newline

> Tools/resultsdbpy/resultsdbpy/view/templates/search.html:220
> +const layoutSizeMayChange = new EventStream();

Feel like this should be something like 'onResizeActions' or 'onLayoutChangeActions'

> Tools/resultsdbpy/resultsdbpy/view/templates/search.html:227
> +

Nit: Extra newline

[Jonathan Bedard]

Comment on attachment 377766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377766&action=review

> Tools/resultsdbpy/resultsdbpy/view/templates/search.html:238
> +    ]), () => layoutSizeMayChange.add()}

Can you double-check parenthesis here? I think this broke the sidebar on my local instance.

[Zhifei Fang]

Created attachment 377772 [details]
Patch

[Zhifei Fang]

(In reply to Jonathan Bedard from comment #3)
> Comment on attachment 377766 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377766&action=review
> 
> > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:137
> > +    const layoutSizeMayChange = new EventStream();
> 
> Feel like this should be something like 'onResizeActions' or
> 'onLayoutChangeActions'
> 
> > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:149
> > +                            /**
> 
> What prompted this new comment format? I know it's pretty common in projects
> which have some sort of auto-documenter, but we don't have that in WebKit.
> 
> > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:155
> > +                                // this make sure the newly added children receive current state
> 
> I would say:
> 'Propigate the current state to new children'
> 
> > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:820
> > +            
> 
> Nit: Extra newline?
> 
> > Tools/resultsdbpy/resultsdbpy/view/templates/search.html:45
> > +
> 
> Nit: Extra newline
> 
> > Tools/resultsdbpy/resultsdbpy/view/templates/search.html:220
> > +const layoutSizeMayChange = new EventStream();
> 
> Feel like this should be something like 'onResizeActions' or
> 'onLayoutChangeActions'
> 
> > Tools/resultsdbpy/resultsdbpy/view/templates/search.html:227
> > +
> 
> Nit: Extra newline


My new API's are all anonynous functions, so I'm adding docstrings to give them a name so that their purpose is clear

[WebKit Commit Bot]

Comment on attachment 377772 [details]
Patch

Clearing flags on attachment: 377772

Committed r249358: <https://trac.webkit.org/changeset/249358>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54908092>