Bug 201355 – [LFC] Pass FormattingContext to Geometry/Quirks/BlockMarginCollapsing classes

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan baradlay]

Instead of the LayoutState. We'll use the formatting context to limit access to display boxes.

[Radar WebKit Bug Importer]

<rdar://problem/54895959>

[alan baradlay]

Created attachment 377749 [details]
Patch

[Antti Koivisto]

Comment on attachment 377749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377749&action=review

> Source/WebCore/layout/FormattingContextQuirks.cpp:56
> +            auto verticalMargin = Geometry(formattingContext()).computedVerticalMargin(*containingBlock, usedValues);

You could do

formattingContext().geometry().computedVerticalMargin()

here and elsewhere

[WebKit Commit Bot]

Comment on attachment 377749 [details]
Patch

Clearing flags on attachment: 377749

Committed r249349: <https://trac.webkit.org/changeset/249349>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[alan baradlay]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 377749 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377749&action=review
> 
> > Source/WebCore/layout/FormattingContextQuirks.cpp:56
> > +            auto verticalMargin = Geometry(formattingContext()).computedVerticalMargin(*containingBlock, usedValues);
> 
> You could do
> 
> formattingContext().geometry().computedVerticalMargin()
> 
> here and elsewhere
That's indeed a good idea. Let me do it in a separate patch.