Bug 201350 - [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
Summary: [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-E...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-30 13:31 PDT by Ryan Haddad
Modified: 2019-08-31 03:57 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.79 KB, patch)
2019-08-30 15:12 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2019-08-30 13:31:05 PDT
As you can see below, the 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests

https://ews-build.webkit.org/#/builders/17/builds/951

run-webkit tests invocation for 'layout-tests' step:
python Tools/Scripts/run-webkit-tests --no-build --no-new-test-results --no-show-results --exit-after-n-failures 30 --skip-failing-tests --debug --dump-render-tree --results-directory layout-test-results --debug-rwt-logging

run-webkit-tests invocation for 're-run-layout-tests' step in the same build:
python Tools/Scripts/run-webkit-tests --no-build --no-new-test-results --no-show-results --exit-after-n-failures 30 --skip-failing-tests --debug --results-directory layout-test-results --debug-rwt-logging

Notice that '--dump-render-tree' is missing.
Comment 1 Radar WebKit Bug Importer 2019-08-30 13:31:25 PDT
<rdar://problem/54894422>
Comment 2 Aakash Jain 2019-08-30 15:12:32 PDT
Created attachment 377754 [details]
Patch
Comment 3 Aakash Jain 2019-08-30 18:17:15 PDT
Tested in: https://ews-build.webkit-uat.org/#/builders/34/builds/257
Comment 4 WebKit Commit Bot 2019-08-30 19:01:16 PDT
Comment on attachment 377754 [details]
Patch

Clearing flags on attachment: 377754

Committed r249355: <https://trac.webkit.org/changeset/249355>
Comment 5 WebKit Commit Bot 2019-08-30 19:01:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Aakash Jain 2019-08-31 03:57:43 PDT
Deployed it on production instance.