Bug 201332 - [JSC] DFG inlining CheckBadCell slow path does not assume result VirtualRegister can be invalid
Summary: [JSC] DFG inlining CheckBadCell slow path does not assume result VirtualRegis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-30 00:10 PDT by Yusuke Suzuki
Modified: 2019-08-30 01:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.70 KB, patch)
2019-08-30 00:18 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-08-30 00:10:54 PDT 
...
Comment 1 Yusuke Suzuki 2019-08-30 00:13:36 PDT 
<rdar://problem/54245190>
Comment 2 Yusuke Suzuki 2019-08-30 00:18:50 PDT 
Created attachment 377684 [details]
Patch
Comment 3 Mark Lam 2019-08-30 00:55:08 PDT 
Comment on attachment 377684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377684&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] DFG inlining CheckBadCell slow path does not assume result VirtualRegister can be inValid

/inValid/invalid/.

> JSTests/ChangeLog:3
> +        [JSC] DFG inlining CheckBadCell slow path does not assume result VirtualRegister can be inValid

Ditto.
Comment 4 Yusuke Suzuki 2019-08-30 01:03:17 PDT 
Comment on attachment 377684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377684&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:3
>> +        [JSC] DFG inlining CheckBadCell slow path does not assume result VirtualRegister can be inValid
> 
> /inValid/invalid/.

Fixed.

>> JSTests/ChangeLog:3
>> +        [JSC] DFG inlining CheckBadCell slow path does not assume result VirtualRegister can be inValid
> 
> Ditto.

Fixed.
Comment 5 Yusuke Suzuki 2019-08-30 01:13:20 PDT 
Committed r249317: <https://trac.webkit.org/changeset/249317>