Bug 201320 – Invalid XPCServices symlinks are being created

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Keith Rollin]

When performing incremental builds, errant XPCServices symlinks can be created. For example, in the following, the second symlink is the correct one. The first symlink gets created when the build process tries to create the symlink and it already exists. When it already exists, the command to create the symlink actually follows the existing symlink and creates the (second) symlink at the location where the first symlink points.

WebKit.framework/Versions/A/XPCServices/XPCServices@ -> Versions/Current/XPCServices
WebKit.framework/XPCServices@ -> Versions/Current/XPCServices

Address this by first removing any previous symlink before creating the new one.

<rdar://problem/54719612>

(In reply to Keith Rollin from comment #0)

> Address this by first removing any previous symlink before creating the new
> one.

The -f option to ln(3) should do this. Perhaps it’s not being specified.

(In reply to mitz from comment #1)
> The -f option to ln(3) should do this. Perhaps it’s not being specified.

I meant ln(1).

Oh but we should also be specifying -h in that case.

[Keith Rollin]

We were specifying -f. I'll use the solution with -h.

[Keith Rollin]

Created attachment 377654 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 377654 [details]
Patch

Clearing flags on attachment: 377654

Committed r249308: <https://trac.webkit.org/changeset/249308>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.