Bug 201320 - Invalid XPCServices symlinks are being created
Summary: Invalid XPCServices symlinks are being created
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-29 16:50 PDT by Keith Rollin
Modified: 2019-08-29 18:57 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.65 KB, patch)
2019-08-29 17:00 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-08-29 16:50:25 PDT
When performing incremental builds, errant XPCServices symlinks can be created. For example, in the following, the second symlink is the correct one. The first symlink gets created when the build process tries to create the symlink and it already exists. When it already exists, the command to create the symlink actually follows the existing symlink and creates the (second) symlink at the location where the first symlink points.

WebKit.framework/Versions/A/XPCServices/XPCServices@ -> Versions/Current/XPCServices
WebKit.framework/XPCServices@ -> Versions/Current/XPCServices

Address this by first removing any previous symlink before creating the new one.

<rdar://problem/54719612>
Comment 1 mitz 2019-08-29 16:51:51 PDT
(In reply to Keith Rollin from comment #0)

> Address this by first removing any previous symlink before creating the new
> one.

The -f option to ln(3) should do this. Perhaps it’s not being specified.
Comment 2 mitz 2019-08-29 16:52:18 PDT
(In reply to mitz from comment #1)
> The -f option to ln(3) should do this. Perhaps it’s not being specified.

I meant ln(1).
Comment 3 mitz 2019-08-29 16:52:57 PDT
Oh but we should also be specifying -h in that case.
Comment 4 Keith Rollin 2019-08-29 16:55:15 PDT
We were specifying -f. I'll use the solution with -h.
Comment 5 Keith Rollin 2019-08-29 17:00:19 PDT
Created attachment 377654 [details]
Patch
Comment 6 WebKit Commit Bot 2019-08-29 18:57:07 PDT
Comment on attachment 377654 [details]
Patch

Clearing flags on attachment: 377654

Committed r249308: <https://trac.webkit.org/changeset/249308>
Comment 7 WebKit Commit Bot 2019-08-29 18:57:09 PDT
All reviewed patches have been landed.  Closing bug.