RESOLVED FIXED 201314
Speculative loads should use the NetworkSession owning their Cache 
https://bugs.webkit.org/show_bug.cgi?id=201314
Summary Speculative loads should use the NetworkSession owning their Cache
Alex Christensen
Reported 2019-08-29 15:25:47 PDT
Speculative loads should use the NetworkSession owning their Cache
Attachments
Patch (6.33 KB, patch)
2019-08-29 15:26 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.88 KB, patch)
2019-08-29 15:31 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-08-29 15:26:58 PDT
Created attachment 377634 [details] Patch
Alex Christensen
Comment 2 2019-08-29 15:31:49 PDT
Created attachment 377635 [details] Patch
WebKit Commit Bot
Comment 3 2019-08-29 17:17:48 PDT
Comment on attachment 377635 [details] Patch Clearing flags on attachment: 377635 Committed r249303: <https://trac.webkit.org/changeset/249303>
WebKit Commit Bot
Comment 4 2019-08-29 17:17:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-08-29 17:18:20 PDT
<rdar://problem/54862251>
Chris Dumez
Comment 6 2020-07-06 14:43:29 PDT
Comment on attachment 377635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377635&action=review > Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:62 > + m_networkLoad = makeUnique<NetworkLoad>(*this, nullptr, WTFMove(parameters), *cache.networkProcess().networkSession(cache.sessionID())); Turns out this may return a null session now and do a null Derek of the session in the NetworkLoad constructor. See Bug 214008.
Note You need to log in before you can comment on or make changes to this bug.