Bug 201312 – Disable CFNetwork AppSSO interception for WebKitLegacy

• Status: NEW
• Component: WebKit Misc.

[Jiewen Tan]

Disable CFNetwork AppSSO interception for WebKitLegacy.

[Radar WebKit Bug Importer]

<rdar://problem/54853399>

[Jiewen Tan]

Created attachment 377624 [details]
Patch

[Sam Weinig]

Comment on attachment 377624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377624&action=review

> Source/WebKitLegacy/mac/ChangeLog:5
> +        Disable CFNetwork AppSSO interception for WebKitLegacy
> +        https://bugs.webkit.org/show_bug.cgi?id=201312
> +        <rdar://problem/54853399>

Please include an explanation of why this change is being made in the ChangeLog.

> Source/WebKitLegacy/mac/WebView/WebView.mm:1592
> +#if HAVE(APP_SSO)
> +    [NSURLSession _disableAppSSO];
> +#endif

What is the effect outside of WebKit of doing this? From the name, it doesn't seem like this would only effect url sessions that WebKit creates, which seems like it could be a problem.

[Jiewen Tan]

Comment on attachment 377624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377624&action=review

Thanks Sam for reviewing the patch.

>> Source/WebKitLegacy/mac/ChangeLog:5
>> +        <rdar://problem/54853399>
> 
> Please include an explanation of why this change is being made in the ChangeLog.

Sure.

>> Source/WebKitLegacy/mac/WebView/WebView.mm:1592
>> +#endif
> 
> What is the effect outside of WebKit of doing this? From the name, it doesn't seem like this would only effect url sessions that WebKit creates, which seems like it could be a problem.

Right. I will double check with CFNetwork if they could provide a per connection version.