Bug 201286 - Simplify PLATFORM expression
Summary: Simplify PLATFORM expression
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-28 21:21 PDT by Keith Rollin
Modified: 2019-08-30 08:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2019-08-29 15:53 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-08-28 21:21:20 PDT 
The preprocessor expression conditionalizing the inclusion of the body of ExitFullscreenOnEnterPiP.mm evolved into:

#if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR))

Simplify this to just:

#if !PLATFORM(IOS_FAMILY_SIMULATOR)
Comment 1 Radar WebKit Bug Importer 2019-08-28 21:21:33 PDT 
<rdar://problem/54822347>
Comment 2 Keith Rollin 2019-08-29 15:53:02 PDT 
Created attachment 377645 [details]
Patch
Comment 3 Alexey Proskuryakov 2019-08-29 19:29:30 PDT 
Comment on attachment 377645 [details]
Patch

I suspect that this conditional was meant for iOS only, and “family” came from a global rename.
Comment 4 WebKit Commit Bot 2019-08-30 08:44:46 PDT 
Comment on attachment 377645 [details]
Patch

Clearing flags on attachment: 377645

Committed r249328: <https://trac.webkit.org/changeset/249328>
Comment 5 WebKit Commit Bot 2019-08-30 08:44:48 PDT 
All reviewed patches have been landed.  Closing bug.