Bug 201280 - Remove HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT conditional
Summary: Remove HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT conditi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-28 20:31 PDT by Keith Rollin
Modified: 2019-08-30 13:27 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.42 KB, patch)
2019-08-29 07:35 PDT, Alex Christensen 		youennf: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-08-28 20:31:13 PDT 
HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT is always True, so remove the conditional tests, keeping the True branches and removing the False branches.
Comment 1 Radar WebKit Bug Importer 2019-08-28 20:31:23 PDT 
<rdar://problem/54821367>
Comment 2 Alex Christensen 2019-08-29 07:35:49 PDT 
Created attachment 377583 [details]
Patch
Comment 3 Darin Adler 2019-08-29 08:59:18 PDT 
Comment on attachment 377583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377583&action=review

> Source/WTF/wtf/Platform.h:-1444
> -/* FIXME: Does this work, and is this needed on other iOS family platforms? */

Do you know the answer to this?
Comment 4 Alex Christensen 2019-08-29 22:23:30 PDT 
Comment on attachment 377583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377583&action=review

>> Source/WTF/wtf/Platform.h:-1444
>> -/* FIXME: Does this work, and is this needed on other iOS family platforms? */
> 
> Do you know the answer to this?

"git show cf848588" in CFNetwork indicates there's nothing platform specific about this.  Alexey added this question in r238785 and I believe it was because he removed a respondsToSelector check which is indeed not needed on any platform.
Comment 5 Alex Christensen 2019-08-30 13:27:51 PDT 
https://trac.webkit.org/changeset/249343/webkit