RESOLVED WONTFIX 201246
[WHLSL] Add discard; statement 
https://bugs.webkit.org/show_bug.cgi?id=201246
Summary [WHLSL] Add discard; statement
Robin Morisset
Reported 2019-08-28 16:01:29 PDT
See https://github.com/gpuweb/WHLSL/issues/54. HLSL documentation: https://docs.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-discard This is kind of required to test the corresponding part of my uniformity analysis: https://bugs.webkit.org/show_bug.cgi?id=201240
Attachments
WIP (14.50 KB, patch)
2019-09-06 14:35 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
WIP (16.93 KB, patch)
2019-09-06 15:15 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
WIP (28.77 KB, patch)
2019-09-09 13:58 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-08-28 16:13:43 PDT
The equivalent metal appears to be the function void discard_fragment(void)
Robin Morisset
Comment 2 2019-09-06 14:35:02 PDT
Created attachment 378235 [details] WIP Missing tests + changelog.
Robin Morisset
Comment 3 2019-09-06 15:15:39 PDT
Created attachment 378244 [details] WIP Fix a couple bugs: - we tolerated discard that were called from non-fragment entry points as long as it was uniformly - we erroneously marked every ternary expression as possibly discarding.
Robin Morisset
Comment 4 2019-09-09 13:58:26 PDT
Created attachment 378406 [details] WIP Added trivial Changelog and a first test. Still missing: - more tests - cleanup of the current test, some of it is cruft copy-pasted from texture-sample-bias which is probably needed.
Myles C. Maxfield
Comment 5 2020-05-05 00:42:51 PDT
WHLSL is no longer relevant.
Note You need to log in before you can comment on or make changes to this bug.