Bug 201224 - Remove support for macOS < 10.13 (part 3)
Summary: Remove support for macOS < 10.13 (part 3)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-28 10:14 PDT by Keith Rollin
Modified: 2019-08-29 12:22 PDT (History)
13 users (show)

See Also:

Attachments
Patch (22.72 KB, patch)
2019-08-28 10:26 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Patch (22.72 KB, patch)
2019-08-28 16:13 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-08-28 10:14:46 PDT 
Remove symbols in WebKitTargetConditionals.xcconfig related to macOS 10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes like _MACOS_SINCE_1013.
Comment 1 Radar WebKit Bug Importer 2019-08-28 10:15:11 PDT 
<rdar://problem/54795934>
Comment 2 Keith Rollin 2019-08-28 10:26:35 PDT 
Created attachment 377458 [details]
Patch
Comment 3 Keith Rollin 2019-08-28 16:12:53 PDT 
Those build failures were because this patch relied on a previous patch having first landed. I had jumped the gun and that previous patch was still in the commit queue and not yet landed.

I'm uploading this patch again now that the previous patch has actually landed.
Comment 4 Keith Rollin 2019-08-28 16:13:48 PDT 
Created attachment 377504 [details]
Patch
Comment 5 WebKit Commit Bot 2019-08-29 12:22:29 PDT 
Comment on attachment 377504 [details]
Patch

Clearing flags on attachment: 377504

Committed r249286: <https://trac.webkit.org/changeset/249286>
Comment 6 WebKit Commit Bot 2019-08-29 12:22:31 PDT 
All reviewed patches have been landed.  Closing bug.