See https://bugs.webkit.org/show_bug.cgi?id=200470.
Created attachment 377449 [details] Patch
Comment on attachment 377449 [details] Patch Clearing flags on attachment: 377449 Committed r249212: <https://trac.webkit.org/changeset/249212>
All reviewed patches have been landed. Closing bug.
<rdar://problem/54803120>
The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a different name?
(In reply to Sam Weinig from comment #5) > The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a > different name? It’s getting renamed to incorporate MathML as a part of MathML revamp. See https://bugs.webkit.org/show_bug.cgi?id=195797 and related bugs.
(In reply to Ryosuke Niwa from comment #6) > (In reply to Sam Weinig from comment #5) > > The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a > > different name? > > It’s getting renamed to incorporate MathML as a part of MathML revamp. > > See https://bugs.webkit.org/show_bug.cgi?id=195797 and related bugs. Ok. It's pretty confusing to have a link to https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement in a comment, which has a different name, without some explanation that the name is going to be changed in the spec at some point.
Comment on attachment 377449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377449&action=review > Source/WebCore/html/HTMLOrForeignElement.idl:26 > +// https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement Yeah, we should probably add a FIXME here referring to https://github.com/mathml-refresh/mathml/issues/83.
(In reply to Sam Weinig from comment #7) > (In reply to Ryosuke Niwa from comment #6) > > (In reply to Sam Weinig from comment #5) > > > The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a > > > different name? > > > > It’s getting renamed to incorporate MathML as a part of MathML revamp. > > > > See https://bugs.webkit.org/show_bug.cgi?id=195797 and related bugs. > > Ok. It's pretty confusing to have a link to > https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement in a > comment, which has a different name, without some explanation that the name > is going to be changed in the spec at some point. Oh, oops, I missed that. Indeed, that's confusing. We should probably add a FIXME there.
Reopening to attach new patch.
Created attachment 377550 [details] Patch
(In reply to Ryosuke Niwa from comment #9) > (In reply to Sam Weinig from comment #7) > > Ok. It's pretty confusing to have a link to > > https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement in a > > comment, which has a different name, without some explanation that the name > > is going to be changed in the spec at some point. > > Oh, oops, I missed that. Indeed, that's confusing. We should probably add a > FIXME there. Agreed, it is confusing, will fix.
Comment on attachment 377550 [details] Patch Clearing flags on attachment: 377550 Committed r249249: <https://trac.webkit.org/changeset/249249>