Bug 201219 - Implement HTMLOrForeignElement
Summary: Implement HTMLOrForeignElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks: 200470
  Show dependency treegraph
 
Reported: 2019-08-28 08:12 PDT by Rob Buis
Modified: 2019-09-05 11:46 PDT (History)
10 users (show)

See Also:


Attachments
Patch (16.18 KB, patch)
2019-08-28 09:04 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (1.18 KB, patch)
2019-08-29 00:12 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2019-08-28 08:12:06 PDT
See https://bugs.webkit.org/show_bug.cgi?id=200470.
Comment 1 Rob Buis 2019-08-28 09:04:35 PDT
Created attachment 377449 [details]
Patch
Comment 2 WebKit Commit Bot 2019-08-28 12:34:50 PDT
Comment on attachment 377449 [details]
Patch

Clearing flags on attachment: 377449

Committed r249212: <https://trac.webkit.org/changeset/249212>
Comment 3 WebKit Commit Bot 2019-08-28 12:34:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-08-28 12:35:18 PDT
<rdar://problem/54803120>
Comment 5 Sam Weinig 2019-08-28 14:42:58 PDT
The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a different name?
Comment 6 Ryosuke Niwa 2019-08-28 17:14:18 PDT
(In reply to Sam Weinig from comment #5)
> The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a
> different name?

It’s getting renamed to incorporate MathML as a part of MathML revamp.

See https://bugs.webkit.org/show_bug.cgi?id=195797 and related bugs.
Comment 7 Sam Weinig 2019-08-28 17:44:42 PDT
(In reply to Ryosuke Niwa from comment #6)
> (In reply to Sam Weinig from comment #5)
> > The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a
> > different name?
> 
> It’s getting renamed to incorporate MathML as a part of MathML revamp.
> 
> See https://bugs.webkit.org/show_bug.cgi?id=195797 and related bugs.

Ok. It's pretty confusing to have a link to https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement in a comment, which has a different name, without some explanation that the name is going to be changed in the spec at some point.
Comment 8 Ryosuke Niwa 2019-08-28 19:38:09 PDT
Comment on attachment 377449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377449&action=review

> Source/WebCore/html/HTMLOrForeignElement.idl:26
> +// https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement

Yeah, we should probably add a FIXME here referring to https://github.com/mathml-refresh/mathml/issues/83.
Comment 9 Ryosuke Niwa 2019-08-28 19:38:36 PDT
(In reply to Sam Weinig from comment #7)
> (In reply to Ryosuke Niwa from comment #6)
> > (In reply to Sam Weinig from comment #5)
> > > The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a
> > > different name?
> > 
> > It’s getting renamed to incorporate MathML as a part of MathML revamp.
> > 
> > See https://bugs.webkit.org/show_bug.cgi?id=195797 and related bugs.
> 
> Ok. It's pretty confusing to have a link to
> https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement in a
> comment, which has a different name, without some explanation that the name
> is going to be changed in the spec at some point.

Oh, oops, I missed that. Indeed, that's confusing. We should probably add a FIXME there.
Comment 10 Rob Buis 2019-08-29 00:11:59 PDT
Reopening to attach new patch.
Comment 11 Rob Buis 2019-08-29 00:12:01 PDT
Created attachment 377550 [details]
Patch
Comment 12 Rob Buis 2019-08-29 00:18:08 PDT
(In reply to Ryosuke Niwa from comment #9)
> (In reply to Sam Weinig from comment #7)
> > Ok. It's pretty confusing to have a link to
> > https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement in a
> > comment, which has a different name, without some explanation that the name
> > is going to be changed in the spec at some point.
> 
> Oh, oops, I missed that. Indeed, that's confusing. We should probably add a
> FIXME there.

Agreed, it is confusing, will fix.
Comment 13 WebKit Commit Bot 2019-08-29 01:30:12 PDT
Comment on attachment 377550 [details]
Patch

Clearing flags on attachment: 377550

Committed r249249: <https://trac.webkit.org/changeset/249249>
Comment 14 WebKit Commit Bot 2019-08-29 01:30:13 PDT
All reviewed patches have been landed.  Closing bug.