Bug 201218 – results.webkit.org: Auto-expand single configurations

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

When displaying only a single configuration in the results database, we should auto-expand the timelines. This is of particular interest when the configuration is 'All', but it also seems valid behavior if the user has only specified one configuration.

[Jonathan Bedard]

Created attachment 377441 [details]
Patch

[Jonathan Bedard]

I was originally pretty skeptical of this change, but after trying it out, I think this will almost always end up saving clicks.

[Aakash Jain]

Comment on attachment 377441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377441&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:480
> +        state: {expanded: options.expanded ? options.expanded : false},

Does this work fine if options.expanded is not defined?
I guess if this is always defined then you could have just used options.expanded instead of ternary operator.

[Jonathan Bedard]

(In reply to Aakash Jain from comment #3)
> Comment on attachment 377441 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377441&action=review
> 
> > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:480
> > +        state: {expanded: options.expanded ? options.expanded : false},
> 
> Does this work fine if options.expanded is not defined?
> I guess if this is always defined then you could have just used
> options.expanded instead of ternary operator.

If options.expand is not defined, than this expression will be 'false'.

With the current code, we probably don't need the ternary operator, but I think it's better to use it so that we're being explicit about what behavior we have if it's undefined.

[Aakash Jain]

rs=me

[Jonathan Bedard]

Created attachment 377447 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 377447 [details]
Patch for landing

Clearing flags on attachment: 377447

Committed r249202: <https://trac.webkit.org/changeset/249202>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54794407>