When displaying only a single configuration in the results database, we should auto-expand the timelines. This is of particular interest when the configuration is 'All', but it also seems valid behavior if the user has only specified one configuration.
Created attachment 377441 [details] Patch
I was originally pretty skeptical of this change, but after trying it out, I think this will almost always end up saving clicks.
Comment on attachment 377441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377441&action=review > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:480 > + state: {expanded: options.expanded ? options.expanded : false}, Does this work fine if options.expanded is not defined? I guess if this is always defined then you could have just used options.expanded instead of ternary operator.
(In reply to Aakash Jain from comment #3) > Comment on attachment 377441 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377441&action=review > > > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:480 > > + state: {expanded: options.expanded ? options.expanded : false}, > > Does this work fine if options.expanded is not defined? > I guess if this is always defined then you could have just used > options.expanded instead of ternary operator. If options.expand is not defined, than this expression will be 'false'. With the current code, we probably don't need the ternary operator, but I think it's better to use it so that we're being explicit about what behavior we have if it's undefined.
rs=me
Created attachment 377447 [details] Patch for landing
Comment on attachment 377447 [details] Patch for landing Clearing flags on attachment: 377447 Committed r249202: <https://trac.webkit.org/changeset/249202>
All reviewed patches have been landed. Closing bug.
<rdar://problem/54794407>