Bug 201202 - Update PACCage changes for builds without Gigacage, but with signed pointers
Summary: Update PACCage changes for builds without Gigacage, but with signed pointers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-27 14:10 PDT by Michael Saboff
Modified: 2019-08-27 16:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.10 KB, patch)
2019-08-27 14:27 PDT, Michael Saboff 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2019-08-27 14:10:53 PDT 
The PACCage changes which landed in r247101 don't properly handle the case where Giga Cage is not enabled, either at compile time or runtime, and we have data pointer signing.  A little restructuring is needed to make it right.
Comment 1 Michael Saboff 2019-08-27 14:11:23 PDT 
<rdar://problem/54571261>
Comment 2 Michael Saboff 2019-08-27 14:27:06 PDT 
Created attachment 377383 [details]
Patch
Comment 3 Saam Barati 2019-08-27 15:06:30 PDT 
Comment on attachment 377383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377383&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +        Update PACCage changes for builds without Giga Cage, but with signed pointers

"Giga Cage" => "Gigacage"

> Source/JavaScriptCore/ChangeLog:8
> +        Factored out the untaging of pointers and added that to both the Giga Cage enabled

"Giga Cage" => "Gigacage"
"untaging" -> "untagging"
Comment 4 Michael Saboff 2019-08-27 16:47:51 PDT 
(In reply to Saam Barati from comment #3)
> Comment on attachment 377383 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377383&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        Update PACCage changes for builds without Giga Cage, but with signed pointers
> 
> "Giga Cage" => "Gigacage"
> 
> > Source/JavaScriptCore/ChangeLog:8
> > +        Factored out the untaging of pointers and added that to both the Giga Cage enabled
> 
> "Giga Cage" => "Gigacage"
> "untaging" -> "untagging"

I made these changes locally.
Comment 5 Michael Saboff 2019-08-27 16:48:56 PDT 
Committed r249184: <https://trac.webkit.org/changeset/249184>