Bug 201200 - GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
Summary: GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-27 13:45 PDT by Dean Jackson
Modified: 2019-08-29 10:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.44 KB, patch)
2019-08-27 13:47 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (1.52 KB, patch)
2019-08-27 16:07 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-08-27 13:45:13 PDT
GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
Comment 1 Dean Jackson 2019-08-27 13:47:34 PDT
Created attachment 377377 [details]
Patch
Comment 2 Dean Jackson 2019-08-27 16:07:39 PDT
Created attachment 377396 [details]
Patch
Comment 3 Dean Jackson 2019-08-28 12:51:14 PDT
Committed r249211: <https://trac.webkit.org/changeset/249211>
Comment 4 Radar WebKit Bug Importer 2019-08-28 12:52:19 PDT
<rdar://problem/54803748>
Comment 5 mitz 2019-08-28 12:59:38 PDT
Comment on attachment 377396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377396&action=review

> Source/WebKitLegacy/mac/Misc/WebDownload.h:38
>  #import <Foundation/NSURLDownload.h>

I don’t see this public header in the latest iOS 13.0 beta SDK. So this doesn’t seem to be a good fix.
Comment 6 Dean Jackson 2019-08-28 18:50:47 PDT
(In reply to mitz from comment #5)
> Comment on attachment 377396 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377396&action=review
> 
> > Source/WebKitLegacy/mac/Misc/WebDownload.h:38
> >  #import <Foundation/NSURLDownload.h>
> 
> I don’t see this public header in the latest iOS 13.0 beta SDK. So this
> doesn’t seem to be a good fix.

Correct. It's a private header. Thanks Dan.
Comment 7 Dean Jackson 2019-08-29 10:21:42 PDT
Reverted in r249281