Bug 201193 - Web Inspector: don't attach properties to `injectedScript` for the CommandLineAPI
Summary: Web Inspector: don't attach properties to `injectedScript` for the CommandLin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 200971
Blocks:
  Show dependency tree / graph
 
Reported: 2019-08-27 12:33 PDT by Devin Rousso
Modified: 2019-08-27 14:41 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2019-08-27 12:36 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (8.00 KB, patch)
2019-08-27 14:07 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-08-27 12:33:56 PDT 
For some reason, specifying `injectedScript._inspectObject` inside CommandLineAPIModuleSource.js causes inspector/debugger/tail-deleted-frames-this-value.html to fail.

We should have a similar approach to adding command line api getters/functions, in that the CommandLineAPIModuleSource.js calls a function with a callback.
Comment 1 Devin Rousso 2019-08-27 12:36:24 PDT 
Created attachment 377367 [details]
Patch
Comment 2 Joseph Pecoraro 2019-08-27 12:37:44 PDT 
Comment on attachment 377367 [details]
Patch

r=me
Comment 3 Devin Rousso 2019-08-27 14:07:19 PDT 
Created attachment 377380 [details]
Patch
Comment 4 WebKit Commit Bot 2019-08-27 14:40:17 PDT 
Comment on attachment 377380 [details]
Patch

Clearing flags on attachment: 377380

Committed r249173: <https://trac.webkit.org/changeset/249173>
Comment 5 WebKit Commit Bot 2019-08-27 14:40:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-27 14:41:17 PDT 
<rdar://problem/54764148>