NEW 201173
DataCue's JSValue should be JSValueInWrappedObject 
https://bugs.webkit.org/show_bug.cgi?id=201173
Summary DataCue's JSValue should be JSValueInWrappedObject
Yusuke Suzuki
Reported 2019-08-26 22:20:24 PDT
...
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2019-08-27 09:12:52 PDT
Yusuke, is this the same as bug 201170?
Radar WebKit Bug Importer
Comment 2 2019-08-27 11:52:43 PDT
<rdar://problem/54757358>
Yusuke Suzuki
Comment 3 2019-08-27 11:57:34 PDT
(In reply to Alexey Proskuryakov from comment #1) > Yusuke, is this the same as bug 201170? DataCue had two problems originally. 1. DataCue was using gcProtect / gcUnprotect, this is wrong 2. DataCue is strongly holding JSValue, which can cause leak if cyclic reference happens. In that issue, I fixed (1), but left (2). This issue is fixing (2).
Note You need to log in before you can comment on or make changes to this bug.