Bug 201173 - DataCue's JSValue should be JSValueInWrappedObject
Summary: DataCue's JSValue should be JSValueInWrappedObject
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-26 22:20 PDT by Yusuke Suzuki
Modified: 2019-08-27 11:57 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-08-26 22:20:24 PDT 
...
Comment 1 Alexey Proskuryakov 2019-08-27 09:12:52 PDT 
Yusuke, is this the same as bug 201170?
Comment 2 Radar WebKit Bug Importer 2019-08-27 11:52:43 PDT 
<rdar://problem/54757358>
Comment 3 Yusuke Suzuki 2019-08-27 11:57:34 PDT 
(In reply to Alexey Proskuryakov from comment #1)
> Yusuke, is this the same as bug 201170?

DataCue had two problems originally.

1. DataCue was using gcProtect / gcUnprotect, this is wrong
2. DataCue is strongly holding JSValue, which can cause leak if cyclic reference happens.

In that issue, I fixed (1), but left (2). This issue is fixing (2).