Bug 201146 – Drop WEBCORE_EXPORT from ChromeClient class

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Drop WEBCORE_EXPORT from ChromeClient class. All its methods and either pure virtual or inlined in the header.

[Chris Dumez]

Created attachment 377264 [details]
Patch

[Alex Christensen]

Comment on attachment 377264 [details]
Patch

r=me, but what does this help?

[Chris Dumez]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 377264 [details]
> Patch
> 
> r=me, but what does this help?

It helps my sanity. Right now, the style checker keeps complaining about this every time I add a new method to this class :)

[Chris Dumez]

(In reply to Chris Dumez from comment #3)
> (In reply to Alex Christensen from comment #2)
> > Comment on attachment 377264 [details]
> > Patch
> > 
> > r=me, but what does this help?
> 
> It helps my sanity. Right now, the style checker keeps complaining about
> this every time I add a new method to this class :)

ERROR: Source/WebCore/page/ChromeClient.h:490:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:491:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]

[WebKit Commit Bot]

Comment on attachment 377264 [details]
Patch

Clearing flags on attachment: 377264

Committed r249119: <https://trac.webkit.org/changeset/249119>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54724331>