RESOLVED FIXED 201140
[EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot
https://bugs.webkit.org/show_bug.cgi?id=201140
Summary [EWS] Do not append additional '(failure)' string at the end of custom failur...
Aakash Jain
Reported 2019-08-26 08:47:37 PDT
In various build-steps in EWS, there is a custom failure message (e.g.: 2 style errors), however an additional (failure) is appended at the end (making it: 2 style errors (failure)). The additional (failure) string in unnecessary and makes the text less readable. We should remove this additional string. Other example: 3 api tests failed or timed out (failure)
Attachments
Patch (3.12 KB, patch)
2019-08-26 09:03 PDT, Aakash Jain
no flags
Aakash Jain
Comment 1 2019-08-26 09:03:14 PDT
EWS Watchlist
Comment 2 2019-08-26 09:05:30 PDT Comment hidden (obsolete)
Aakash Jain
Comment 3 2019-08-26 09:06:45 PDT
Jonathan Bedard
Comment 4 2019-08-26 09:23:34 PDT
Comment on attachment 377248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377248&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:509 > + return {u'step': unicode(status)} What prompted this change? Do we have an example of status being something other than ASCII?
Aakash Jain
Comment 5 2019-08-26 09:40:28 PDT
Comment on attachment 377248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377248&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:509 >> + return {u'step': unicode(status)} > > What prompted this change? Do we have an example of status being something other than ASCII? The above code refactoring prompted this. Earlier the 'status' variable was always unicode. After this change, in case of self.failedTestCount, 'status' is not unicode, so we need to convert it to unicode. Buildbot expects the returned status to be unicode (and throws an exception if it's not a unicode).
WebKit Commit Bot
Comment 6 2019-08-26 10:48:18 PDT
Comment on attachment 377248 [details] Patch Clearing flags on attachment: 377248 Committed r249104: <https://trac.webkit.org/changeset/249104>
WebKit Commit Bot
Comment 7 2019-08-26 10:48:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-08-26 10:49:19 PDT
Note You need to log in before you can comment on or make changes to this bug.