Bug 201139 - run-webkit-tests: Cap the number of automatically booted simulators at 12
Summary: run-webkit-tests: Cap the number of automatically booted simulators at 12
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-26 07:50 PDT by Jonathan Bedard
Modified: 2019-08-26 10:22 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.92 KB, patch)
2019-08-26 07:58 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (2.44 KB, patch)
2019-08-26 08:27 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-08-26 07:50:58 PDT
It seems that with a larger number of cores and memory, simulators start to be bound by some other system resource. In particular, contributors with iMac Pros and 128 GB of RAM will boot between 16 and 20 simulators, and begin to see diminishing returns on how fast simulator tests are run. By default, we should cap the number of simulators we automatically boot at 12. Note that this change will not have an effect on the number of simulators booted unless a machine is automatically booting more than 12 simulators.
Comment 1 Jonathan Bedard 2019-08-26 07:58:26 PDT
Created attachment 377245 [details]
Patch
Comment 2 Jonathan Bedard 2019-08-26 08:05:14 PDT
In particular, some testing a year or two back indicated that RAM was usually the bottleneck when booting simulators, and 128 GB of RAM could boot up to 21 simulators...if you have that much RAM, CPU will usually be considered the bottleneck, which would leave you with 18, in most cases. Getting some feedback from different folks, it seems like this is rarely desired.
Comment 3 Aakash Jain 2019-08-26 08:07:42 PDT
Comment on attachment 377245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377245&action=review

> Tools/Scripts/webkitpy/xcode/simulated_device.py:422
> +        max_supported_simulators_for_hardware = min(host.executive.cpu_count() // 2, host.platform.total_bytes_memory() // SimulatedDeviceManager.MEMORY_ESTIMATE_PER_SIMULATOR_INSTANCE, 12)

Please store 12 in a separate variable, something like MAX_NUMBER_OF_SIMULATORS.
Comment 4 Jonathan Bedard 2019-08-26 08:27:20 PDT
Created attachment 377246 [details]
Patch
Comment 5 WebKit Commit Bot 2019-08-26 10:21:34 PDT
Comment on attachment 377246 [details]
Patch

Clearing flags on attachment: 377246

Committed r249102: <https://trac.webkit.org/changeset/249102>
Comment 6 WebKit Commit Bot 2019-08-26 10:21:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-26 10:22:18 PDT
<rdar://problem/54711790>