NEW 201118
REGRESSION (r241660): CachedTypes.cpp is often recompiled during incremental builds because the Derived Sources build phase always touches BytecodeCacheVersion.h 
https://bugs.webkit.org/show_bug.cgi?id=201118
Summary REGRESSION (r241660): CachedTypes.cpp is often recompiled during incremental ...
Andy Estes
Reported 2019-08-24 11:21:40 PDT
--- trunk/Source/JavaScriptCore/DerivedSources.make 2019-02-18 09:12:48 UTC (rev 241659) +++ trunk/Source/JavaScriptCore/DerivedSources.make 2019-02-18 10:20:28 UTC (rev 241660) @@ -356,3 +356,10 @@ all : \ $(OBJECT_LUT_HEADERS) \ # + +.PHONY : BytecodeCacheVersion.h + +BytecodeCacheVersion.h: + echo "#define JSC_BYTECODE_CACHE_VERSION $(shell date '+%s')" > BytecodeCacheVersion.h + +all : BytecodeCacheVersion.h BytecodeCacheVersion.h has no dependencies, so it's always updated with the current date when the Derived Sources build phase runs. CachedTypes.cpp includes BytecodeCacheVersion.h.
Attachments
Add attachment proposed patch, testcase, etc.
Note You need to log in before you can comment on or make changes to this bug.