Bug 201118 - REGRESSION (r241660): CachedTypes.cpp is often recompiled during incremental builds because the Derived Sources build phase always touches BytecodeCacheVersion.h
Summary: REGRESSION (r241660): CachedTypes.cpp is often recompiled during incremental ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 194768
Blocks:
  Show dependency tree / graph
 
Reported: 2019-08-24 11:21 PDT by Andy Estes
Modified: 2019-08-25 12:21 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-08-24 11:21:40 PDT 
--- trunk/Source/JavaScriptCore/DerivedSources.make	2019-02-18 09:12:48 UTC (rev 241659)
+++ trunk/Source/JavaScriptCore/DerivedSources.make	2019-02-18 10:20:28 UTC (rev 241660)
@@ -356,3 +356,10 @@
 all : \
     $(OBJECT_LUT_HEADERS) \
 #
+
+.PHONY : BytecodeCacheVersion.h
+
+BytecodeCacheVersion.h:
+	echo "#define JSC_BYTECODE_CACHE_VERSION $(shell date '+%s')" > BytecodeCacheVersion.h
+
+all : BytecodeCacheVersion.h

BytecodeCacheVersion.h has no dependencies, so it's always updated with the current date when the Derived Sources build phase runs. CachedTypes.cpp includes BytecodeCacheVersion.h.