Bug 201109 - Add a script to update ANGLE
Summary: Add a script to update ANGLE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
: 201013 (view as bug list)
Depends on:
Blocks: webglangle
  Show dependency tree / graph
 
Reported: 2019-08-23 17:34 PDT by James Darpinian
Modified: 2020-03-11 14:43 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.66 KB, patch)
2019-08-23 17:35 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2019-08-23 17:34:05 PDT 
Add a script to update ANGLE
Comment 1 James Darpinian 2019-08-23 17:35:57 PDT 
Created attachment 377186 [details]
Patch
Comment 2 James Darpinian 2019-08-23 17:37:19 PDT 
*** Bug 201013 has been marked as a duplicate of this bug. ***
Comment 3 EWS Watchlist 2019-08-23 17:38:13 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 James Darpinian 2019-08-23 17:40:04 PDT 
This is no longer moving ANGLE to a different directory, it's just a single script file now.
Comment 5 Alex Christensen 2019-08-26 10:03:34 PDT 
Comment on attachment 377186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377186&action=review

> Source/ThirdParty/ANGLE/update-angle.sh:51
> +if ! git am changes.diff; then

This won't work for anyone using svn, but that's probably no big deal.
Comment 6 WebKit Commit Bot 2019-08-26 10:36:35 PDT 
Comment on attachment 377186 [details]
Patch

Clearing flags on attachment: 377186

Committed r249103: <https://trac.webkit.org/changeset/249103>
Comment 7 WebKit Commit Bot 2019-08-26 10:36:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-08-26 10:38:39 PDT 
<rdar://problem/54712643>
Comment 9 James Darpinian 2019-08-26 10:41:41 PDT 
Thanks! I believe the script should work for svn users as long as they have git installed. The script runs git in a clone of the ANGLE git repo, not the main WebKit repo.