Bug 201106 - [LFC] Box::isAnonymous() can not rely on the lack of ElementType.
Summary: [LFC] Box::isAnonymous() can not rely on the lack of ElementType.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-23 16:51 PDT by zalan
Modified: 2019-08-24 06:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.15 KB, patch)
2019-08-23 16:55 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-08-23 16:51:07 PDT 
TableWrapperBox is an anonymous box with "TableWrapperBox" element type.
Comment 1 Radar WebKit Bug Importer 2019-08-23 16:52:30 PDT 
<rdar://problem/54660287>
Comment 2 zalan 2019-08-23 16:55:33 PDT 
Created attachment 377182 [details]
Patch
Comment 3 Antti Koivisto 2019-08-24 00:03:01 PDT 
Comment on attachment 377182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377182&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:202
> +    bool m_isAnonymous { false };
> +
>      unsigned m_baseTypeFlags : 6;
>      bool m_hasRareData : 1;

Could include this to the bitfield below.
Comment 4 zalan 2019-08-24 06:34:54 PDT 
Committed r249085: <https://trac.webkit.org/changeset/249085>