Bug 201095 - Web Inspector: "Copy Rule" menu item does not propagate comments properly
Summary: Web Inspector: "Copy Rule" menu item does not propagate comments properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-23 15:25 PDT by Joseph Pecoraro
Modified: 2019-08-24 11:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.27 KB, patch)
2019-08-23 16:12 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-08-23 15:25:53 PDT
"Copy Rule" menu item does not propagate comments properly

Steps to Reproduce:
1. Inspect <body> on about:blank
2. Add some properties
3. Disable some properties
4. Click Rule Icon > Copy Rule
5. Paste
  => Disabled "commented out" properties are not commented out
Comment 1 Devin Rousso 2019-08-23 16:12:51 PDT
Created attachment 377173 [details]
Patch
Comment 2 Joseph Pecoraro 2019-08-24 10:38:50 PDT
Comment on attachment 377173 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-08-24 11:21:10 PDT
Comment on attachment 377173 [details]
Patch

Clearing flags on attachment: 377173

Committed r249089: <https://trac.webkit.org/changeset/249089>
Comment 4 WebKit Commit Bot 2019-08-24 11:21:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-08-24 11:22:20 PDT
<rdar://problem/54673898>