WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
201092
Move foldQuoteMarks and foldQuoteMark out of TextIterator
https://bugs.webkit.org/show_bug.cgi?id=201092
Summary
Move foldQuoteMarks and foldQuoteMark out of TextIterator
Wenson Hsieh
Reported
2019-08-23 15:16:05 PDT
…foldQuoteMarks isn’t specific to TextIterator; after
https://webkit.org/b/201085
, it should really be moved to a common utility file. That said, I’m unsure where the best home for this would be. WTFString.h? Perhaps StringCommon.h? Or maybe a new private header in WebCore? 🤔
Attachments
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2019-08-23 16:35:16 PDT
One other consideration: I think that also the specific implementation we were using in TextIterator.cpp was scoped to just what we needed in *addition* to what's already done by usearch. Other call sites might eventually want something that would go beyond that.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug