Bug 201059 - All image drawing functions should take an argument of type ImagePaintingOptions
Summary: All image drawing functions should take an argument of type ImagePaintingOptions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 201123
  Show dependency tree / graph
 
Reported: 2019-08-22 17:33 PDT by Said Abou-Hallawa
Modified: 2019-08-28 13:23 PDT (History)
4 users (show)

See Also:

Attachments
Patch (119.77 KB, patch)
2019-08-22 17:52 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (150.83 KB, patch)
2019-08-22 18:26 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (154.18 KB, patch)
2019-08-22 19:00 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (154.17 KB, patch)
2019-08-22 19:06 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (154.18 KB, patch)
2019-08-23 00:32 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (154.15 KB, patch)
2019-08-23 00:48 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (156.68 KB, patch)
2019-08-23 01:10 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (160.83 KB, patch)
2019-08-23 01:29 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (161.04 KB, patch)
2019-08-23 01:34 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (165.79 KB, patch)
2019-08-23 09:52 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (166.38 KB, patch)
2019-08-23 14:10 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (163.79 KB, patch)
2019-08-27 11:20 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (155.30 KB, patch)
2019-08-28 11:47 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (12) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-08-22 17:33:02 PDT 
1) Pass ImagePaintingOptions to all the image drawing functions. Currently the top level drawing functions pass only some member of ImagePaintingOptions to lower level functions.
2) ImagePaintingOptions should be initialized with any number of the options and the order options should not matter. Currently it is hard to get the right set of constructors of ImagePaintingOptions because some callers prefers to pass few options and have the rest of options fall back to the default values.
Comment 1 Said Abou-Hallawa 2019-08-22 17:52:37 PDT 
Created attachment 377083 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-08-22 18:26:07 PDT 
Created attachment 377087 [details]
Patch
Comment 3 Said Abou-Hallawa 2019-08-22 19:00:55 PDT 
Created attachment 377089 [details]
Patch
Comment 4 Said Abou-Hallawa 2019-08-22 19:06:43 PDT 
Created attachment 377090 [details]
Patch
Comment 5 Said Abou-Hallawa 2019-08-23 00:32:12 PDT 
Created attachment 377107 [details]
Patch
Comment 6 Said Abou-Hallawa 2019-08-23 00:48:42 PDT 
Created attachment 377108 [details]
Patch
Comment 7 Said Abou-Hallawa 2019-08-23 01:10:47 PDT 
Created attachment 377112 [details]
Patch
Comment 8 Said Abou-Hallawa 2019-08-23 01:29:08 PDT 
Created attachment 377115 [details]
Patch
Comment 9 Said Abou-Hallawa 2019-08-23 01:34:33 PDT 
Created attachment 377116 [details]
Patch
Comment 10 Said Abou-Hallawa 2019-08-23 09:52:09 PDT 
Created attachment 377131 [details]
Patch
Comment 11 Said Abou-Hallawa 2019-08-23 14:10:56 PDT 
Created attachment 377153 [details]
Patch
Comment 12 Radar WebKit Bug Importer 2019-08-26 16:53:26 PDT 
<rdar://problem/54728479>
Comment 13 Said Abou-Hallawa 2019-08-27 11:20:24 PDT 
Created attachment 377357 [details]
Patch
Comment 14 Said Abou-Hallawa 2019-08-28 11:47:19 PDT 
Created attachment 377466 [details]
Patch
Comment 15 WebKit Commit Bot 2019-08-28 13:23:46 PDT 
Comment on attachment 377466 [details]
Patch

Clearing flags on attachment: 377466

Committed r249217: <https://trac.webkit.org/changeset/249217>
Comment 16 WebKit Commit Bot 2019-08-28 13:23:48 PDT 
All reviewed patches have been landed.  Closing bug.