WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
201056
serial_test_WTFOptionSetProvider_empty should assert that provider.size == 0 and extract last child is m_storage into separate test
https://bugs.webkit.org/show_bug.cgi?id=201056
Summary
serial_test_WTFOptionSetProvider_empty should assert that provider.size == 0 ...
Daniel Bates
Reported
2019-08-22 15:14:23 PDT
Following the fix for
bug #200742
I realized that the test named serial_test_WTFOptionSetProvider_empty [1] would be more intuitive to understand if it asserted that provider.size == 0. We should then add another unit test that checks that the last synthetic child is 'm_storage' (we always place this as the last synthetic child, the synthetic provider never includes it in the child count though to prevent it from showing up when listing the synthetic children). [1] <
https://trac.webkit.org/browser/trunk/Tools/lldb/lldb_webkit_unittest.py?rev=248531#L185
>
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug