Bug 201052 - Remove logging that contains a URL
Summary: Remove logging that contains a URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-22 14:00 PDT by Keith Rollin
Modified: 2019-08-22 14:44 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2019-08-22 14:02 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (1.92 KB, patch)
2019-08-22 14:12 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-08-22 14:00:34 PDT
checkURLReceivedFromWebProcess in WebProcessProxy.cpp contains an old logging line that logs a URL. We don't log URLs any more for privacy reasons, so remove this.

A search for WTFLogAlways.*url turns up other matches, but those are either false positives or cases where the URLs are logged only on demand by the developer as part of debugging. checkURLReceivedFromWebProcess is the only place where a URL is logged as a matter of course.
Comment 1 Radar WebKit Bug Importer 2019-08-22 14:00:52 PDT
<rdar://problem/54613204>
Comment 2 Keith Rollin 2019-08-22 14:02:42 PDT
Created attachment 377042 [details]
Patch
Comment 3 Chris Dumez 2019-08-22 14:08:53 PDT
Comment on attachment 377042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377042&action=review

> Source/WebKit/UIProcess/WebProcessProxy.cpp:-561
> -    WTFLogAlways("Received an unexpected URL from the web process: '%s'\n", url.string().utf8().data());

Shouldn't we keep the logging though? How to we know now that's why the load is failing?
Comment 4 Keith Rollin 2019-08-22 14:12:44 PDT
Created attachment 377043 [details]
Patch
Comment 5 WebKit Commit Bot 2019-08-22 14:44:00 PDT
Comment on attachment 377043 [details]
Patch

Clearing flags on attachment: 377043

Committed r249029: <https://trac.webkit.org/changeset/249029>
Comment 6 WebKit Commit Bot 2019-08-22 14:44:01 PDT
All reviewed patches have been landed.  Closing bug.