Bug 201042 – Web Inspector: REGRESSION(r248485): stack overflow when viewing a source map generated from inline content

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

RangeError:​ Maximum call stack size exceeded. (at Object.js:​172:​17)​
    dispatchEventToListeners @ Object.js:​172:​17
    markAsFinished @ Resource.js:​894:​38
    sourceMapResourceLoaded @ SourceMapResource.js:​121:​32
    requestContent @ SourceCode.js:​140:​100
    _tryEnableCustomResponseContentView @ ResourceClusterContentView.js:​371:​38
    _resourceLoadingDidFinish @ ResourceClusterContentView.js:​331:​49
    dispatch @ Object.js:​165:​30
    dispatchEventToListeners @ Object.js:​172:​17
    markAsFinished @ Resource.js:​894:​38
    sourceMapResourceLoaded @ SourceMapResource.js:​121:​32
    requestContent @ SourceCode.js:​140:​100
    _tryEnableCustomResponseContentView @ ResourceClusterContentView.js:​371:​38
    _resourceLoadingDidFinish @ ResourceClusterContentView.js:​331:​49
    dispatch @ Object.js:​165:​30
    dispatchEventToListeners @ Object.js:​172:​17
    markAsFinished @ Resource.js:​894:​38
    ...

[Devin Rousso]

<rdar://problem/54509750>

[Devin Rousso]

Created attachment 377019 [details]
Patch

I haven't tested this, as I am in the middle of a build, but logically this should work :P

[Joseph Pecoraro]

Comment on attachment 377019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377019&action=review

> Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:87
> +            return Promise.resolve().then(sourceMapResourceLoaded.bind(this, {content: inlineContent, mimeType: this.mimeType, statusCode: 200}));

I like this solution! I noticed this the other day and did something similar but this is even better!

[WebKit Commit Bot]

Comment on attachment 377019 [details]
Patch

Clearing flags on attachment: 377019

Committed r249037: <https://trac.webkit.org/changeset/249037>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.